GH#265: Preserve Guzzle HTTP error responses - #266
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #266 +/- ##
============================================
+ Coverage 86.49% 86.52% +0.02%
Complexity 1327 1327
============================================
Files 68 68
Lines 4295 4297 +2
============================================
+ Hits 3715 3718 +3
+ Misses 580 579 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
send()pathResolves #265
Testing
vendor/bin/phpunit tests/unit/Providers/Http/HttpTransporterTest.php— 12 tests, 56 assertionsvendor/bin/phpunit tests/unit/Providers/Http/Util/ResponseUtilTest.php— 9 tests, 18 assertionscomposer test:unit— 1,166 tests, 4,271 assertionscomposer lint— PHPCS 207 files; PHPStan 111 files, no errorscomposer validate --strictcomposer check-platform-reqsRuntime Testing
Self-assessed against the repository's Guzzle-shaped test client: the focused tests execute the options path and verify both 529-to-
ServerExceptionand 400-to-ClientExceptiontranslation. The repository does not installguzzlehttp/guzzle; live provider integration tests were not run because they make billable API calls and do not exercise this option bridge.Decisions
The new option is scoped to
buildGuzzleOptions(), so ordinary PSR-18 clients andClientWithOptionsInterfaceimplementations remain unchanged. No retries or dependency changes are introduced.aidevops.sh v3.32.191 plugin for OpenCode v1.18.5 with gpt-5.6-sol spent 33m and 118,309 tokens on this with the user in an interactive session. Overall, 4h 36m since this issue was created.