Disable submit button when plugin is not selected#212
Merged
mukeshpanchal27 merged 5 commits intotrunkfrom Jun 28, 2023
Merged
Conversation
felixarntz
reviewed
Jun 26, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
Thanks @jjgrainger for the PR. Only two small points of feedback here to improve the behavior a bit further. There's one edge-case we should probably address, which should be straightforward.
| } | ||
|
|
||
| // Handle disabling the check it button when a plugin is not selected. | ||
| pluginsList.addEventListener( 'change', canRunChecks ); |
Member
There was a problem hiding this comment.
Nit-pick: Maybe move this together with the canRunChecks() call, just to have those two places where the function is called co-located?
Contributor
Author
There was a problem hiding this comment.
Thanks @felixarntz I've moved this down with the canRunChecks() call.
mukeshpanchal27
approved these changes
Jun 28, 2023
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @jjgrainger, The changes look good to me.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables the 'Check it' button when a plugin is not selected in the dropdown.
This has been tested and works with the 'Check this plugin' links on the plugins page.
Closes #139