Skip to content

Disable submit button when plugin is not selected #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mukeshpanchal27 merged 5 commits into from
Jun 28, 2023
Merged

Disable submit button when plugin is not selected #212

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7fa1862
disable submit button when plugin is not selected
jjgrainger Jun 26, 2023
79f4512
disable plugin dropdown when checks run
jjgrainger Jun 27, 2023
d80c1be
Merge branch 'trunk' into feature/disable-admin-button
jjgrainger Jun 27, 2023
11cb166
Apply suggestions from code review
mukeshpanchal27 Jun 28, 2023
1c765df
Merge branch 'trunk' into feature/disable-admin-button
mukeshpanchal27 Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions assets/js/plugin-check-admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,26 @@
return;
}

// Handle disabling the Check it button when a plugin is not selected.
function canRunChecks() {
if ( '' === pluginsList.value ) {
checkItButton.disabled = true;
} else {
checkItButton.disabled = false;
}
}
Comment thread
felixarntz marked this conversation as resolved.

// Run on page load to test if dropdown is auto populated.
canRunChecks();
pluginsList.addEventListener( 'change', canRunChecks );

// When the Check it button is clicked.
checkItButton.addEventListener( 'click', ( e ) => {
e.preventDefault();

resetResults();
checkItButton.disabled = true;
pluginsList.disabled = true;
spinner.classList.add( 'is-active' );

getChecksToRun()
Expand Down Expand Up @@ -54,6 +69,7 @@
function resetForm() {
spinner.classList.remove( 'is-active' );
checkItButton.disabled = false;
pluginsList.disabled = false;
}

/**
Expand Down