Skip to content

Add file related functions in the exclusion list of alternative functions rule - #838

Merged
davidperezgar merged 2 commits into
trunkfrom
update-alternative-function-exclusion
Dec 20, 2024
Merged

Add file related functions in the exclusion list of alternative functions rule#838
davidperezgar merged 2 commits into
trunkfrom
update-alternative-function-exclusion

Conversation

@ernilambar

@ernilambar ernilambar commented Dec 18, 2024

Copy link
Copy Markdown
Member

Following functions are added in the exclusion list for alternative functions rule:

  • WordPress.WP.AlternativeFunctions.file_get_contents_file_get_contents
  • WordPress.WP.AlternativeFunctions.file_system_operations_file_put_contents

Above function calls are giving almost always false positives. So those should be reviewed manually.

@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugins Issues owned by Plugins Team labels Dec 18, 2024
@ernilambar
ernilambar marked this pull request as ready for review December 18, 2024 09:44
@github-actions

github-actions Bot commented Dec 18, 2024

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: davidperezgar <davidperez@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar added this to the 1.4.0 milestone Dec 19, 2024
@davidperezgar
davidperezgar merged commit 9990e92 into trunk Dec 20, 2024
@davidperezgar
davidperezgar deleted the update-alternative-function-exclusion branch December 20, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Team] Plugins Issues owned by Plugins Team [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants