Skip to content

Duplicated message for file type check - #840

Merged
davidperezgar merged 2 commits into
trunkfrom
duplicated-message-file-type-check
Dec 20, 2024
Merged

Duplicated message for file type check#840
davidperezgar merged 2 commits into
trunkfrom
duplicated-message-file-type-check

Conversation

@ernilambar

@ernilambar ernilambar commented Dec 20, 2024

Copy link
Copy Markdown
Member

For file .DS_Store, two errors are triggered: hidden_files and application_detected

In this PR, I have removed DS_Store extension from the list of application extensions.

For .DS_Store file, hidden_files error is already triggered. So, I believe application check should not test for DS_Store.

This will fix duplicated message for the same file.

PR also includes scenario in the feature test for the related change.

@ernilambar ernilambar added [Type] Bug An existing feature is broken [Team] Plugins Issues owned by Plugins Team labels Dec 20, 2024
@ernilambar
ernilambar marked this pull request as ready for review December 20, 2024 07:25
@github-actions

github-actions Bot commented Dec 20, 2024

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: davidperezgar <davidperez@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar added this to the 1.4.0 milestone Dec 20, 2024
@davidperezgar
davidperezgar merged commit 46f3018 into trunk Dec 20, 2024
@davidperezgar
davidperezgar deleted the duplicated-message-file-type-check branch December 20, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Team] Plugins Issues owned by Plugins Team [Type] Bug An existing feature is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants