Support PHP 7.2 in Reprint exporter by fredrikekelund · Pull Request #335 · WordPress/reprint

fredrikekelund · 2026-07-09T15:06:38Z

Background

Our initial strategy for shipping the Reprint exporter to Pressable sites is to include it in the stock Jetpack plugin. The Reprint exporter already lives in wpcomsh (which is part of Jetpack), so the tactic is:

Duplicate that implementation in the regular Jetpack plugin, gating the Reprint exporter feature to Pressable and WoA sites.
After deploying that change, update the Reprint client to use the new Jetpack API URLs to interact with the Reprint exporter.
Remove the wpcomsh Reprint exporter implementation from the Jetpack repo.

One obvious concern here is, "Is it really good UX to deploy this through Jetpack?" The answer is that we are doing this to support Studio sync, which already depends on Jetpack for Pressable sites to work, and Jetpack also gives us auth. Long-term, it is very likely there'll be a standalone Reprint exporter plugin, just not to begin with.

What is this PR?

The standard Jetpack plugin supports PHP 7.2. To be able to include the Reprint exporter there, we need to update the Reprint exporter code to work with PHP 7.2 This PR does just that.

The client is not affected. You can still use newer PHP syntax and features there.

Testing instructions

CI should pass

github-actions · 2026-07-09T15:08:55Z

Pull pipeline performance — `large-directory`

Site: large-directory · 2,000+ plus targeted file-transfer scenarios files · 10,000 posts · 25,000 postmeta · PHP 8.5.8

Stage	PR	trunk	Δ	Status	Details
`playground-sqlite-db-pull`	9.38 s	9.08 s	⚪ +305 ms (+3.4%)	✓	condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected trunk: condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected
`playground-sqlite-db-apply`	3.58 s	3.52 s	⚪ +59 ms (+1.7%)	✓	condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified trunk: condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified
Total	12.96 s	12.60 s	⚪ +364 ms (+2.9%)

_{Numbers carry runner noise; treat single-run deltas as directional, not authoritative.}

_{📈 Trunk performance history — commit-by-commit timeline.}

fredrikekelund · 2026-07-09T20:14:34Z

+          - exporter_php: '7.2'
+            importer_php: '8.2'


The importer still only supports PHP>=7.4, which is why I separated exporter_php and importer_php versions

fredrikekelund · 2026-07-09T20:24:37Z

-          timeout 30 php "$IMPORTER_PATH" preflight "${BASE}&directory=${DIR}" /tmp/e2e-smoke --secret="${SECRET}" 2>&1 | head -50 || echo "EXIT: $?"
+          preflight_output="$(timeout 30 "$IMPORTER_PHP" "$IMPORTER_PATH" preflight "${BASE}&directory=${DIR}" --state-dir="${STATE_DIR}" --fs-root="${FS_ROOT}" --secret="${SECRET}" 2>&1)" || {
+            status=$?
+            echo "$preflight_output" | head -50
+            echo "EXIT: $status"
+            exit "$status"
+          }
+          echo "$preflight_output" | head -50

          echo "=== Importer files-pull ==="
-          timeout 30 php "$IMPORTER_PATH" files-pull "${BASE}&directory=${DIR}" /tmp/e2e-smoke --secret="${SECRET}" 2>&1 | head -50 || echo "EXIT: $?"
+          files_pull_output="$(timeout 30 "$IMPORTER_PHP" "$IMPORTER_PATH" files-pull "${BASE}&directory=${DIR}" --state-dir="${STATE_DIR}" --fs-root="${FS_ROOT}" --secret="${SECRET}" 2>&1)" || {
+            status=$?
+            echo "$files_pull_output" | head -50
+            echo "EXIT: $status"
+            exit "$status"
+          }
+          echo "$files_pull_output" | head -50


The old testing command ended with head -50 || echo "EXIT: $?", meaning we would only echo EXIT: $STATUS if head failed (which it basically never does). Importantly, the script would also not actually exit – it'd just echo EXIT: 1.

These changes trigger an actual failure if an error happens here.

fredrikekelund · 2026-07-09T20:33:38Z

-		-
-			message: "#^Strict comparison using \\!\\=\\= between null and null will always evaluate to false\\.$#"
-			count: 1
-			path: packages/reprint-exporter/src/class-file-tree-producer.php
-


class-file-tree-producer.php changed in a way that there is no longer an error to suppress

fredrikekelund · 2026-07-09T21:29:01Z

CI was passing on 518f4f5, so the more recent failures look like potential flukes

adamziel · 2026-07-10T00:01:39Z

+      # via two PHPCompatibility runs (see lint:php:compat in composer.json).
+      - run: composer lint:php:compat
+
+  syntax-72:


Good call! This will prevent drift

The reprint-exporter package previously required PHP >=7.4, but the Jetpack plugin supports PHP >=7.2, so the PHP 7.2/7.3 test jobs could not install it. WordPress/reprint#335 added PHP 7.2 support, published as wp-php-toolkit/reprint-exporter v0.9.1 (php >=7.2). Bump the constraint from ^0.1.47 to ^0.9.1 and regenerate the lock; the transitive wp-php-toolkit/* dependencies move from v0.6.2 to v0.8.1. The exporter API used by Jetpack (Site_Export_HMAC_Server, Site_Export_HTTP_Server) is unchanged.

Support PHP 7.2 in Reprint exporter

cef29e5

fredrikekelund requested review from adamziel and epeicher July 9, 2026 15:06

fredrikekelund self-assigned this Jul 9, 2026

Fix lockfile

1fa89fb

fredrikekelund mentioned this pull request Jul 9, 2026

Add Reprint exporter outside wpcomsh Automattic/jetpack#50369

Open

fredrikekelund added 3 commits July 9, 2026 17:20

Fix tests

c43c2a0

Update phpstan

b3782be

Fix setup for PHP 7.2

518f4f5

fredrikekelund commented Jul 9, 2026

View reviewed changes

Clarify comment

6806a0b

fredrikekelund commented Jul 9, 2026

View reviewed changes

Comment

c02a4b2

adamziel reviewed Jul 10, 2026

View reviewed changes

adamziel merged commit fd8d6bb into trunk Jul 10, 2026
27 of 30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support PHP 7.2 in Reprint exporter#335

Support PHP 7.2 in Reprint exporter#335
adamziel merged 7 commits into
trunkfrom
f26d/exporter-php-72-support

fredrikekelund commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026 •

edited

Loading

Uh oh!

fredrikekelund Jul 9, 2026

Uh oh!

fredrikekelund Jul 9, 2026

Uh oh!

fredrikekelund Jul 9, 2026

Uh oh!

fredrikekelund commented Jul 9, 2026

Uh oh!

adamziel Jul 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

fredrikekelund commented Jul 9, 2026

Background

What is this PR?

Testing instructions

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull pipeline performance — large-directory

Uh oh!

fredrikekelund Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

fredrikekelund Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

fredrikekelund Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

fredrikekelund commented Jul 9, 2026

Uh oh!

adamziel Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jul 9, 2026 •

edited

Loading

Pull pipeline performance — `large-directory`