Infinite builds loop fix - #150
Merged
Merged
Conversation
Member
|
I was thinking: Now that we found the way to exclude paths from the watcher, we could also have webpack copy the schema.json into |
Member
Author
|
@psrpinto Good point! I will try that in a separate PR :) |
Member
|
We ended up pushing that change in #148 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we decided to not drop a generated file into
srcdir for WP so as to avoid the situation of generated file re-triggering a build.schema.jsonis now only generated underschemadir and copied to the right places under the build dir. And is now also configured to be ignored by webpack's watching for changes.This resolves the infinite loop of building assets.