Unify API controller - #163
Merged
Merged
Conversation
…nly controller class
…jects controller class
psrpinto
approved these changes
Dec 13, 2024
psrpinto
left a comment
psrpinto
left a comment
Member
There was a problem hiding this comment.
I think this is a great change, brings us closer to our goal of not needing to make changes to the code when we add new type of subject 👌
I didn't test it locally, I'm assuming everything still works as it did before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges the multiple controller classes into a singular one, changes the endpoint url and now frontend also uses that.