Skip to content

Fix PHPStan level 0 issues for Customizer setting subclasses by returning correct types#10952

Closed
westonruter wants to merge 3 commits intoWordPress:trunkfrom
westonruter:fix/phpstan-customizer
Closed

Fix PHPStan level 0 issues for Customizer setting subclasses by returning correct types#10952
westonruter wants to merge 3 commits intoWordPress:trunkfrom
westonruter:fix/phpstan-customizer

Conversation

@westonruter
Copy link
Member

@westonruter westonruter commented Feb 17, 2026

The changes in this PR were cherry-picked (e.g. 2f72407 and 22370b6) from #10419 for Core-61175.

This Customizer ensures return type consistency for the update methods for setting classes. In practice, these methods are protected and the return value is never read, so it's just about housekeeping. It keeps the overridden methods compatible with the parent class's method.

Trac ticket: https://core.trac.wordpress.org/ticket/64238

Use of AI Tools

n/a


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@westonruter
Copy link
Member Author

@justlevine Would you give this a review for me?

Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and is testing well:

Testing notes:

  • Activate 2014
  • Add header image
  • Confirm
  • Remove header image
  • Confirm
  • Add a menu
  • Place it in header (primary)
  • confirm
  • Add items to menu
  • confirm

Confirm indicates:

  • dynamically updated in the customizer
  • saved when publish button hit
  • displayed on front end after hitting publsih

pento pushed a commit that referenced this pull request Feb 18, 2026
…ides return consistent types.

This addresses PHPStan type check issues.

Developed in #10952

Props westonruter, peterwilsoncc, justlevine.
See #64238, #61175.


git-svn-id: https://develop.svn.wordpress.org/trunk@61670 602fd350-edb4-49c9-b593-d223f7449a82
@westonruter
Copy link
Member Author

Committed in r61670 (ff7564a)

markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Feb 18, 2026
…ides return consistent types.

This addresses PHPStan type check issues.

Developed in WordPress/wordpress-develop#10952

Props westonruter, peterwilsoncc, justlevine.
See #64238, #61175.

Built from https://develop.svn.wordpress.org/trunk@61670


git-svn-id: http://core.svn.wordpress.org/trunk@60978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants