Skip to content

Refactor: Remove unnecessary false check in oEmbed data fetching#11126

Closed
Soean wants to merge 2 commits intoWordPress:trunkfrom
Soean:oembed_data_fetch
Closed

Refactor: Remove unnecessary false check in oEmbed data fetching#11126
Soean wants to merge 2 commits intoWordPress:trunkfrom
Soean:oembed_data_fetch

Conversation

@Soean
Copy link
Member

@Soean Soean commented Mar 3, 2026

This pull request makes a small change to the get_data method in class-wp-oembed.php, simplifying the method by removing an unnecessary conditional check before returning the fetched data.

Trac ticket: https://core.trac.wordpress.org/ticket/64784


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props soean, swissspidy, ocean90.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

pento pushed a commit that referenced this pull request Mar 3, 2026
Developed in #11126

Follow up to r40628.

Props soean, swissspidy, ocean90, sajib1223, manhar.
Fixes #64784.


git-svn-id: https://develop.svn.wordpress.org/trunk@61797 602fd350-edb4-49c9-b593-d223f7449a82
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61797
GitHub commit: c6c1256

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Mar 3, 2026
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Mar 3, 2026
Developed in WordPress/wordpress-develop#11126

Follow up to r40628.

Props soean, swissspidy, ocean90, sajib1223, manhar.
Fixes #64784.

Built from https://develop.svn.wordpress.org/trunk@61797


git-svn-id: http://core.svn.wordpress.org/trunk@61103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@Soean Soean deleted the oembed_data_fetch branch March 3, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants