Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
|
||
| public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) { | ||
| update_option( 'wp_enable_real_time_collaboration', true ); | ||
| add_filter( 'pre_option_wp_disable_real_time_collaboration', '__return_false' ); |
There was a problem hiding this comment.
Why do we need this after the flip?
There was a problem hiding this comment.
Same for a lot of the instances above
There was a problem hiding this comment.
We are testing both code paths, both default and when it has been disabled.
I'm adding the filter for both code paths in case we change our mind on opt-in / opt-out. That way, no code changes will be needed.
There was a problem hiding this comment.
I think it's fine to have the code changes tbh, but I don't mind either way
The option name is changed since the previous option name set a default value during database initialization. A default is no longer needed since the default is false. Developed in: #11159. Fixes #64622. Props czarate. git-svn-id: https://develop.svn.wordpress.org/trunk@61828 602fd350-edb4-49c9-b593-d223f7449a82
The option name is changed since the previous option name set a default value during database initialization. A default is no longer needed since the default is false. Developed in: WordPress/wordpress-develop#11159. Fixes #64622. Props czarate. Built from https://develop.svn.wordpress.org/trunk@61828 git-svn-id: http://core.svn.wordpress.org/trunk@61115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2 participants
Trac ticket: https://core.trac.wordpress.org/ticket/64622
Enable RTC by default (opt-out). This reverses a previous decision for WP 7.0 Beta 1 to keep it opt-in.
Note that we must update the option name since the previous option name set a default value during database initialization. We have removed the option from initialization so that future updates will not require an option name change.