First pass at constant for forcing enable/disable of real time collab#11310
First pass at constant for forcing enable/disable of real time collab#11310aaronjorbin wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| <input name="wp_collaboration_enabled" type="checkbox" id="wp_collaboration_enabled" value="1" <?php checked( '1', (bool) get_option( 'wp_collaboration_enabled' ) ); ?> /> | ||
| <?php _e( 'Enable real-time collaboration' ); ?> | ||
| </label> | ||
| <?php if ( defined ( 'FORCE_COLLABORATION_ENABLED' ) ) : ?> |
There was a problem hiding this comment.
What do you think about inverting this to WP_DISABLE_COLLABORATION? Just so the purpose is only disabling collaboration, but if it's WP_DISABLE_COLLABORATION === false it's still up to the site administrator.
I think for a host disabling collaboration could make sense, but define( 'FORCE_COLLABORATION_ENABLED', true ); is a bit odd to force-enable it, especially if there are "feature preview" issues.
There was a problem hiding this comment.
Noting that based on feedback it's been changed to WP_ALLOW_COLLABORATION and allows for the feature to be disallowed on an environment level.
|
I added a modified version of this using |
3 participants
This is the start at adding a constant for forcing enable/disable for real time collab. Currently only includes UI changes
Trac ticket: https://core.trac.wordpress.org/ticket/64904
Use of AI Tools
AI assistance: Yes
Tool(s): Claude
Model(s): GPT-5.1
Used for: Initial code skeleton and test suggestions; final implementation and tests were reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.