Remove RTC from 7.0 release branch#11767
Closed
maxschmeling wants to merge 57 commits into
Closed
Conversation
git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62159 602fd350-edb4-49c9-b593-d223f7449a82
Reviewed by SergeyBiryukov. See #64966. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62162 602fd350-edb4-49c9-b593-d223f7449a82
…down on the setup screen. This changeset ensures the hover/focus color of the setup screen's language dropdown use the new default admin color scheme. Reviewed by SergeyBiryukov. Merges [62163] to the 7.0 branch. Props huzaifaalmesbah, noruzzaman. Fixes #64961. See #64308. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62164 602fd350-edb4-49c9-b593-d223f7449a82
Configured the Real Time Collaboration post type to be excluded from exports by default. The data is considered ephemeral and includes data on post IDs that may not match the IDs of posts on the importing site. Introduces a test to the export test suite to ensure that post types set to be excluded from exports are, in fact, excluded from exports. Reviewed by westonruter, desrosj, jorbin. Merges r62168 to the 7.0 branch. Props peterwilsoncc, desrosj, westonruter, jorbin, mukesh27, czarate. Fixes #64964. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62169 602fd350-edb4-49c9-b593-d223f7449a82
`line-height` values that were previously used to match the height of input fields affect the height of the background shown when text inside those fields is selected. Removing these `line-height` declarations allows the text selection highlight to render more naturally. Additionally, update the height of the custom Date/Time format input fields on the General Settings screen to `32px` to align with the new design system. Reviewed by wildworks, audrasjb. Merges [62171] to the 7.0 branch. Props arkaprabhachowdhury, audrasjb, hmrisad, huzaifaalmesbah, manhar, manishxdp, noruzzaman, ozgursar, r1k0, sachinrajcp123, wildworks. Fixes #64763. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62172 602fd350-edb4-49c9-b593-d223f7449a82
In [62145], an ::after CSS rule was added that caused an overflow, resulting in an unintended scrollbar always appearing on Windows OS for example. This changeset removes the related CSS rule which is unnecessary to fix the initial issue. Follow-up to [62145]. Reviewed by wildworks, SergeyBiryukov. Merges [62187] to the 7.0 branch. Props wildworks, SergeyBiryukov, sabernhardt, audrasjb, huzaifaalmesbah, mehrazmorshed, mukesh27. Fixes #64744. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62190 602fd350-edb4-49c9-b593-d223f7449a82
Validate `setting_name`, `constant_name`, and `env_var_name` in connector
registration — reject invalid values with `_doing_it_wrong()` instead of
silently falling back.
Change the auto-generated `setting_name` pattern from
`connectors_ai_{$id}_api_key` to `connectors_{$type}_{$id}_api_key` so it
works for any connector type. Built-in AI providers infer their names using
the existing `connectors_ai_{$id}_api_key` convention, preserving backward
compatibility.
Add `constant_name` and `env_var_name` as optional authentication fields,
allowing connectors to declare explicit PHP constant and environment
variable names for API key lookup. AI providers auto-generate these using
the `{CONSTANT_CASE_ID}_API_KEY` convention.
Refactor `_wp_connectors_get_api_key_source()` to accept explicit
`env_var_name` and `constant_name` parameters instead of deriving them from
the provider ID. Environment variable and constant checks are skipped when
not provided.
Generalize REST dispatch, settings registration, and script module data to
work with all connector types, not just `ai_provider`. Settings
registration skips already-registered settings. Non-AI connectors determine
`isConnected` based on key source.
Replace `isInstalled` with `pluginFile` in script module data output to fix
plugin entity ID resolution on the frontend.
Update PHPDoc to reflect current behavior — widen `type` from literal
`'ai_provider'` to `non-empty-string`, document new authentication fields,
and use Anthropic examples throughout.
Props gziolo, jorgefilipecosta.
Fixes #64957.
git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62194 602fd350-edb4-49c9-b593-d223f7449a82
…ation. Use the plugin's main file path relative to the plugins directory (e.g. `akismet/akismet.php` or `hello.php`) instead of the WordPress.org slug to identify a connector's associated plugin. This lets `_wp_connectors_get_connector_script_module_data()` check plugin status with `file_exists()` and `is_plugin_active()` directly, removing the `get_plugins()` slug-to-file mapping that was previously needed. Props jorgefilipecosta, mukesh27, gziolo. Fixes #65002. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62195 602fd350-edb4-49c9-b593-d223f7449a82
…st tables. Follow-up to [61645]. Reviewed by audrasjb, SergeyBiryukov. Merges [62182] to the 7.0 branch. Props TobiasBg, rcorrales, opurockey, rahultank, SergeyBiryukov. Fixes #64975. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62197 602fd350-edb4-49c9-b593-d223f7449a82
Update min-height from 30px to 32px for the color picker button and related elements to match new design system. Reviewed by joedolson, wildworks. Merges [62191] to the 7.0 branch. Props audrasjb, hmbashar, huzaifaalmesbah, joedolson, juanmaguitar, mukesh27, noruzzaman, ozgursar, rahultank, rcorrales, sajib1223, shailu25, tusharaddweb, vgnavada, wildworks. Fixes #64761. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62202 602fd350-edb4-49c9-b593-d223f7449a82
…e screen. Follow-up to [61645]. Reviewed by wildworks, SergeyBiryukov. Merges [62196] to the 7.0 branch. Props mukesh27, wildworks, audrasjb, shailu25, anupkankale, kapilpaul, SergeyBiryukov. Fixes #65009. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62203 602fd350-edb4-49c9-b593-d223f7449a82
Update the colors used for the file upload overlay mask to use the new admin theme colors. Reviewed by wildworks. Merges 62199 to the 7.0 branch. Props opurockey, huzaifaalmesbah, wildworks, audrasjb, manhar, joedolson. Fixes #65001. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62204 602fd350-edb4-49c9-b593-d223f7449a82
The design changes to admin notices links in the admin refresh were applied broadly to .notice, .error, and .updated classes, but these classes are sometimes used outside the context of an admin notice. Change selectors from .notice a, .error a, .updated a to div.notice a, div.error a, div.updated a. Reviewed by audrasjb. Merges [62200] to the 7.0 branch. Props opurockey, audrasjb, vgnavada, gaisma22, shailu25, rbcorrales, joedolson. Fixes #64976. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62211 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned hash from the `gutenberg` from `0d133bf7e7437d65d68a06551f3d613a7d8e4361` to `e2970ba736edb99e08fb369d4fb0c378189468ee`. The following changes are included: - WordPress/gutenberg#76478 Boot: Fix black area below content when sidebar is taller than page c… (WordPress/gutenberg#76764) - Style Book: Fix missing styles for classic themes in stylebook route (WordPress/gutenberg#76843) - RTC: Fix stuck "Join" link in post list when lock expires (WordPress/gutenberg#76795) - Icon: Fix center alignment in the editor for classic themes (WordPress/gutenberg#76878) - RTC: Fix notes not syncing between collaborative editors (WordPress/gutenberg#76873) - Latest Comments: Fix v1 deprecated block missing supports (WordPress/gutenberg#76877) - Connectors: Add Akismet as a default connector (WordPress/gutenberg#76828) - Restore with compaction update (WordPress/gutenberg#76872) - Improve JSDoc for abilities API (WordPress/gutenberg#76824) - Connectors: Replace plugin.slug with plugin.file (WordPress/gutenberg#76909) - Block visibility badge: use canvas iframe for viewport detection (WordPress/gutenberg#76889) - Connectors: Update help text from 'reset' to 'manage' (WordPress/gutenberg#76963) - Connectors: Hide Akismet unless already installed (WordPress/gutenberg#76962) - Wrap sync update processing in try/catch (WordPress/gutenberg#76968) - Backport: Improve validation and permission checks for `WP_HTTP_Polling_Sync_Server` (WordPress/gutenberg#76987) - Connectors: account for mu-plugins when resolving plugin.file status (WordPress/gutenberg#76994) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/0d133bf7e7437d65d68a06551f3d613a7d8e4361…e2970ba736edb99e08fb369d4fb0c378189468ee. Log created with: git log --reverse --format="- %s" 0d133bf7e7437d65d68a06551f3d613a7d8e4361..e2970ba736edb99e08fb369d4fb0c378189468ee | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62212 602fd350-edb4-49c9-b593-d223f7449a82
This changeset fixes a CSS glitch on dashboard widgets bottom border when they are collapsed. Follow-up to [61646]. Reviewed by westonruter. Merges [62206] to the 7.0 branch. Props pratik-jain, audrasjb, ankitkumarshah. Fixes #65017. See #64549. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62214 602fd350-edb4-49c9-b593-d223f7449a82
… "Bulk Edit". The "Bulk Edit" translation string is used for both verbs and nouns, and may have different translations in some Locales. This changeset helps disambuguating these different contexts. Follow-up to [61255]. Reviewed by westonruter. Merges [62186] to the 7.0 branch. Props audrasjb, shailu25. Fixes #64994. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62215 602fd350-edb4-49c9-b593-d223f7449a82
Set `_wp_ignored_hooked_blocks` post meta in the REST API response sent from post-like endpoints that support Block Hooks (see `rest_block_hooks_post_types` filter). Previously, it was enough to set that post meta on write (i.e. save to DB). However, due to the way real-time collaboration syncs posts and reconciles them with content received from the server side, this information is now vital on the client side to ensure hooked blocks aren't duplicated. Developed in WordPress#11410. Reviewed by jonsurrell. Merges [62219] to the 7.0 branch. Props bernhard-reiter, czarate, ingeniumed. Fixes #65008. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62220 602fd350-edb4-49c9-b593-d223f7449a82
…pse and move buttons. Fixes an issue where the focus outline on metabox collapse buttons and move handles was being clipped. Reviewed by audrasjb, wildworks. Merges [62232] to the 7.0 branch. Props abcd95, audrasjb, brianhogg, darshitrajyaguru97, poena, wildworks. Fixes #65060. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62235 602fd350-edb4-49c9-b593-d223f7449a82
…setup screen. This changeset updates the link colors on the setup screen and the default wp_die() fallback styles to use the new default admin color scheme. Reviewed by audrasjb, wildworks. Merges [62230] to the 7.0 branch. Props audrasjb, darshitrajyaguru97, dhrumilk, hbhalodia, huzaifaalmesbah, ismail0071, mikinc860, pooja-n, shailu25, sumitsingh, vishitshah, wildworks Fixes #64962. See #64308. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62236 602fd350-edb4-49c9-b593-d223f7449a82
…n WP_Error. Wraps `invoke_callback()` in a try/catch so that exceptions thrown by execute or permission callbacks are converted to a `WP_Error` with the `ability_callback_exception` code instead of propagating as uncaught throwables. Developed in: WordPress#11544 Reviewed by adamsilverstein, justlevine, jorbin. Merges [62238] to the 7.0 branch. Props priyankagusani, jamesgiroux, jeffpaul, dkotter, adamsilverstein, justlevine, jorbin, pavanpatil1. Fixes #65058. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62240 602fd350-edb4-49c9-b593-d223f7449a82
…T` constant. When `WP_AI_SUPPORT` is explicitly set to `false`, `wp_supports_ai()` now returns early before the filter runs. This ensures the site owner's explicit preference to disable AI cannot be overridden by a plugin via the `wp_supports_ai` filter. The filter default is now always `true`, since the constant check happens beforehand. Developed in: WordPress#11295 Follow-up to [62067]. Reviewed by justlevine, westonruter, adamsilverstein. Merges [62239] to the 7.0 branch. Props justlevine, westonruter, gziolo, mindctrl, adamsilverstein, johnjamesjacoby, ahortin, nilambar, ozgursar, audrasjb, jeffpaul. Fixes #64706. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62241 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [37849]. Reviewed by jorbin, audrasjb. Merges [62188] to the 7.0 branch. Props timse201, anupkankale, sergeyBiryukov. Fixes #65005. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62242 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that not only the return values match the expected results, but also that their type is the same. Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable. Follow-up to [61700]. Reviewed by peterwilsoncc. Merges r62248 to the 7.0 branch. Props sagardeshmukh, SergeyBiryukov. See #64324. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62265 602fd350-edb4-49c9-b593-d223f7449a82
…_Builder`. This checks that the return value of the `wp_ai_client_default_request_timeout` filter is a non-negative number before passing it to `RequestOptions`. If the filtered value is invalid, it is discarded in favor of the original default of `30.0` and a `_doing_it_wrong()` notice is issued. Without this check, a fatal error would ensue from the exception thrown in `\WordPress\AiClient\Providers\Http\DTO\RequestOptions::validateTimeout()`. The following static analysis issues are addressed: * Use `float` instead of `int` for the `wp_ai_client_default_request_timeout` filter parameter. * Add missing PHP imports for `Message` and `MessagePart` in the PHPDoc for `wp_ai_client_prompt()`. * Add PHP return type hints for `wp_ai_client_prompt()` and `WP_AI_Client_Cache::getMultiple()`. * Use native property type hints in `WP_AI_Client_HTTP_Client`. Developed in WordPress#11596 Reviewed by peterwilsoncc. Merges r62255 to the 7.0 branch. Props westonruter, justlevine, flixos90, khushdoms, darshitrajyaguru97, adrmf25, jarodortegaaraya, tusharaddweb, gaurangsondagar. Fixes #65094. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62266 602fd350-edb4-49c9-b593-d223f7449a82
Reviewed by peterwilsoncc. Merges r62256 to the 7.0 branch. Props timse201, sanketparmar, trickster301, audrasjb, jadavsanjay, SergeyBiryukov. Fixes #64982. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62267 602fd350-edb4-49c9-b593-d223f7449a82
Modifies the Screen Options > Number of items per page field to avoid cropping of three digit numbers when setting a list view to display a lot of items. Reviewed by audrasjb. Merges r62268 to the 7.0 branch. Props apermo, audrasjb, darshitrajyaguru97, ekla, gaurangsondagar, jigarkahar, juanmaguitar, khushdoms, peterwilsoncc, sabernhardt, shailu25, shatrumyatra, yusufmudagal. Fixes #65104. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62269 602fd350-edb4-49c9-b593-d223f7449a82
Reduces the size and improves the alignment of the post slug field following the re-design of form elements as part of the new admin theme. Reviewed by wildworks. Merges r62263 to the 7.0 branch. Props wildworks, sabernhardt, audrasjb, dhruvang21, shailu25, joedolson, khushdoms, tusharaddweb. Fixes #65063. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62270 602fd350-edb4-49c9-b593-d223f7449a82
This changeset corrects a misalignment issue affecting the show/hide button next to the password field. Reviewed by peterwilsoncc. Merges [62262] and [62272] to the 7.0 branch. Props piyushpatel123, rajdiptank111, ankitkumarshah, andrewssanya, jdahir0789, gautammkgarg, gaurangsondagar, gaisma22, ugyensupport, abduremon, ankitmaru, darshitrajyaguru97, khushdoms, monzuralam, mukesh27, wildworks. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62274 602fd350-edb4-49c9-b593-d223f7449a82
Relocates the copy-vendor-scripts to run during the the build:js portion of the build script. This ensures the JavaScript files are in place before the uglify:all task is run. Follow up to r61438. Reviewed by desrosj, peterwilsoncc. Merges [62189] to the 7.0 branch. Props desrosj, peterwilsoncc. Fixes #65006. See #64393. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62275 602fd350-edb4-49c9-b593-d223f7449a82
… files are minified. Relocates the copying of vendor JavaScript files back to the `grunt copy:vendor-js` subtask to ensure the files are in place prior to the grunt uglify step running to minify the files. Reviewed by desrosj, peterwilsoncc. Merges [62258] to the 7.0 branch. Props desrosj, peterwilsoncc. Fixes #65007. See #64393. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62276 602fd350-edb4-49c9-b593-d223f7449a82
This update adds 1 certificate to the bundle. Reviewed by desrosj, peterwilsoncc. Merges [62271] to the 7.0 branch. Props desrosj, peterwilsoncc. Fixes #64245. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62277 602fd350-edb4-49c9-b593-d223f7449a82
Align the Previous, Next, and Restore This Revision buttons consistently across viewports on the revisions comparison screen. Reviewed by peterwilsoncc. Merges [62273] to the 7.0 branch. Props audrasjb, mokshasharmila13, peterwilsoncc, presskopp, shailu25, wildworks. Fixes #65062. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62280 602fd350-edb4-49c9-b593-d223f7449a82
Adds additional validation and permission checks the the Real Time Collaboration endpoint to ensure only input in the expected format is supported. Reviewed by peterwilsoncc, audrasjb. Merges [62198] to the 7.0 branch. Props czarate, westonruter, joefusco, peterwilsoncc. Fixes #64890. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62283 602fd350-edb4-49c9-b593-d223f7449a82
…th classic editor. Follow-up to [61646], [61759]. Reviewed by peterwilsoncc. Merges r62284 to the 7.0 branch. Props umeshnevase, sabernhardt, SergeyBiryukov. Fixes #65141. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62285 602fd350-edb4-49c9-b593-d223f7449a82
Add automatic translation loading for script modules (ES modules), so strings using `__()` and friends from `@wordpress/i18n` can be translated at runtime. This brings classic script i18n parity to script modules registered via `wp_register_script_module()`, which previously had no way to load translation data, leaving strings untranslated on screens like Connectors and Fonts that are built as script modules. At the `admin_print_footer_scripts` and `wp_footer` actions, every enqueued script module and its dependencies are walked, the translation chunk is loaded for each, and an inline `<script>` calls `wp.i18n.setLocaleData()` so translations are available before deferred modules execute. Note there is currently a runtime dependency on the `wp-i18n` classic script, which is printed just-in-time if not already enqueued. This coupling is to be removed in a future release. Public API: * `WP_Script_Modules::set_translations()` stores the text domain (and optional path) per registered module to override the text domain and path. A global `wp_set_script_module_translations()` function is added as a wrapper around `wp_script_modules()->set_translations()`. * `WP_Script_Modules::get_registered()` obtains a registered module's data. See #60597. * `WP_Script_Modules::print_script_module_translations()` emits inline `wp.i18n.setLocaleData()` calls after classic scripts load but before modules execute. * `load_script_module_textdomain()` loads the translation data for a given script module ID and text domain. * The existing `load_script_textdomain_relative_path` filter gains a third `$is_module` parameter so callers can distinguish classic-script and script-module lookups when resolving translation paths. PHPStan types are also added in `WP_Script_Modules`. See #64238. Developed in WordPress#11543 Reviewed by audrasjb. Merges r62278 to the 7.0 branch. Props manzoorwanijk, westonruter, jsnajdr, jonsurrell, mukesh27, peterwilsoncc, 369work, desrosj, sabernhardt, nilambar, jorgefilipecosta, malayladu. See #64238, #60597. Fixes #65015. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62286 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [38880], [61645]. Reviewed by peterwilsoncc. Merges r62279 to the 7.0 branch. Props umesh.nevase, sabernhardt, SergeyBiryukov. Fixes #65133. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62287 602fd350-edb4-49c9-b593-d223f7449a82
…ss capability Adds capability-gated CSS stripping so that when a user without `edit_css` saves a post, any `style.css` block attributes are removed from block comments using `WP_Block_Parser::next_token()`. Reviewed by audrasjb, peterwilsoncc. Merges [62257], [62299] to the 7.0 branch. Props aaronrobertshaw, audrasjb, dmsnell, glendaviesnz, jonsurrell, ozgursar, ramonopoly, shailu25, westonruter. Follow-up to [64544]. Fixes #64771. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62300 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [61646]. Reviewed by peterwilsoncc. Merges r62295 to the 7.0 branch. Props mohitbsf, wildworks, joedolson, audrasjb, huzaifaalmesbah, SergeyBiryukov. Fixes #64689. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62301 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [61646]. Reviewed by audrasjb. Merges r62290 to the 7.0 branch. Props wildworks, mukesh27, shailu25, noruzzaman, darshitrajyaguru97, SergeyBiryukov. Fixes #64987. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62302 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [61646]. Reviewed by peterwilsoncc. Merges r62291 to the 7.0 branch. Props wildworks, anupkankale, shailu25, gaurangsondagar, jadavsanjay, SergeyBiryukov. Fixes #65131. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62303 602fd350-edb4-49c9-b593-d223f7449a82
Prevent Real-Time Collaboration sessions from becoming out of sync when an offline editor returns to an online state. The change ensures that the updates are merged rather than discarded when each client is at a different cursor after reconnecting or experiencing slow network conditions. Reviewed by ramonopoly. Merges r62298 to the 7.0 branch. Props alecgeatches, peterwilsoncc, maxschmeling, joefusco. See #64622. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62304 602fd350-edb4-49c9-b593-d223f7449a82
Remove WordPress-internal properties (`sanitize_callback`, `validate_callback`, `arg_options`) from ability `input_schema` and `output_schema` fields in REST responses. These properties are used server-side but are not valid JSON Schema keywords and cause client-side validators to fail. Reviewed by gziolo, desrosj. Merges [62221] to the 7.0 branch. Props jorgefilipecosta, ocean90, gziolo, desrosj. Fixes #65035. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62305 602fd350-edb4-49c9-b593-d223f7449a82
Update `_wp_register_default_connector_settings()` to register a connector's default API key setting only when the connector's `plugin.is_active` callback returns `true`. Add tests covering the gate's branches: setting skipped when `is_active` returns `false`, setting registered when it returns `true`. Reviewed by desrosj. Merges [62289] to the 7.0 branch. Props jorgefilipecosta, gziolo, peterwilsoncc. Fixes #65099. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62306 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [61827], [62171]. Reviewed-by wildworks, jorbin. Merges [62296] to the 7.0 branch. Props wildworks, mukesh27, audrasjb, SergeyBiryukov. Fixes #64685. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62307 602fd350-edb4-49c9-b593-d223f7449a82
This merges the modifications from [62210] that were not directly reverting the changes in [62193] to the 7.0 branch. While [62193] never made its way into the 7.0 branch, these changes are needed to ensure backports touching these lines are able to complete without merge conflicts. Reviewed by desrosj. Partially merges [62210] to the 7.0 branch. Props peterwilsoncc, jorgefilipecosta, johnbillion, eclev91, desrosj, davidbaumwald, jorbin. See #65012. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62308 602fd350-edb4-49c9-b593-d223f7449a82
Adds an optional `is_active` callable to the `plugin` definition accepted by `WP_Connector_Registry::register()`. The callback receives no arguments, must return a boolean, and is used by the Connectors screen to decide whether a connector's backing plugin is currently active. When omitted, it defaults to `__return_true`; when provided but not callable, registration fails with a `_doing_it_wrong()` notice. Developed in: WordPress#11565 Reviewed by desrosj. Merges [62288] to the 7.0 branch. Props iamadisingh, jorgefilipecosta, mukesh27, gziolo, desrosj. Fixes #65020. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62309 602fd350-edb4-49c9-b593-d223f7449a82
Reviewed by jorbin, audrasjb. Merges [62312] to the 7.0 branch. Props shailu25, audrasjb, timse201, sanketparmar. Fixes #64983. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62315 602fd350-edb4-49c9-b593-d223f7449a82
… "Notes". "Notes" translation string is used in both the Notes features and in the Link Manager, and they can have different meaning in some Locales, like in German for example. This changeset helps disambuguating these different contexts. Reviewed by desrosj, audrasjb. Merges [62185] to the 7.0 branch. Props timse201, sanketparmar. Fixes #64980. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62316 602fd350-edb4-49c9-b593-d223f7449a82
Swap the default and hover color rules for admin bar icons on mobile so icons use `$menu-icon` by default and `$menu-submenu-focus-text` on hover. Reviewed by audrasjb. Merges [62317] to the 7.0 branch. Props sabernhardt, peterwilsoncc, wildworks. Fixes #65140. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62318 602fd350-edb4-49c9-b593-d223f7449a82
Akismet is bundled with WordPress core, but it wasn't appearing on the Connectors screen even when present on the file system. Partially reverts [62210], bringing back the main part of [62193]. Follow-up to [62210], [62193]. Developed in WordPress#11688. Reviewed by gziolo. Merges [62310] to the 7.0 branch. Props audrasjb, bluefuton, davidbaumwald, desrosj, eclev91, gziolo, johnbillion, jorbin, jorgefilipecosta, lukecarbis, matt, matveb, peterwilsoncc, westonruter. Fixes #65012. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62319 602fd350-edb4-49c9-b593-d223f7449a82
Introduces a JavaScript fallback for determining whether the command palette icon in the toolbar should display ⌘Kfor Apple devices. This is to account for sites behind a CDN as it's common for the User-Agent header to be stripped from the request sent to the application server in order to increase cache hits on the edge. Reviewed by westonruter, desrosj. Merges [62282] to the 7.0 branch. Props peterwilsoncc, westonruter, mukesh27, ramonopoly, desrosj. Fixes #65121. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62322 602fd350-edb4-49c9-b593-d223f7449a82
This updates the JavaScript based regular expression to be case-insensitive, which matches the corresponding PHP pattern. A defensive check has alos been added to avoid a `TypeError` if the admin bar is manipulated in a way that changes the path of the targeted element. Follow up to [62282]. Reviewed by westonruter, desrosj, jorbin. Merges [62320] to the 7.0 branch. Props westonruter, dersosj, jorbin. Fixes #65121. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62323 602fd350-edb4-49c9-b593-d223f7449a82
…src(). This guards against an undefined index warning being raised when a script or script module is registered with a URL that lacks a path component. This also adds full PHPStan type definitions for wp_parse_url(), ensuring that the _load_script_textdomain_from_src() function has no PHPStan errors at rule level 10. Developed in WordPress#11690 Follow-up to r62278. Reviewed by desrosj, jorbin. Merges [62293] to the 7.0 branch. Props westonruter, manzoorwanijk, mukesh27. See #65015, #64238. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62325 602fd350-edb4-49c9-b593-d223f7449a82
[61757] wrapped the media attachment filters, which changed the return value of toolbar filters from `AttachmentFilters` to a `wp.media.View` instance, breaking the API to customize media library filters. Reverts the shape change in the attachment filter return value and implements CSS based positioning for the visible labels. Reviewed by jorbin. Merges [62326] to the 7.0 branch. Props bernhard-reiter, joedolson, ozgursar, audrasjb, darshitrajyaguru97, jorbin. Fixes #64948. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62327 602fd350-edb4-49c9-b593-d223f7449a82
In [61458], a `postinstall` script was introduced that ensured the source code from the `gutenberg` repository was present before attempting to run the build script. The WordPress.org Hosting Tests surfaced an edge case where the `postinstall` script was failing when `nodevenv` is used. Because it serves as a wrapper for Node.js, `NPM_CONFIG_PREFIX` is set to the virual envirnoment directory and not the actual project source directory. This removes `gutenberg:verify` from `postinstall` entirely. `gutenberg:verify` is responsible for confirming that the `gutenberg` directory exists, that the commit SHA value in `gutenberg/.gutenberg-hash` matches `gutenberg.sha` in the `package.json` file, and it downloads a fresh copy if not. While this will result in the necessary files not being present locally after running `npm install`, `gutenberg:verify` is specified as the first task executed when the `build` and `build:dev` scripts are run. Running either build script has been a requirement to run WordPress locally for some time now, so this does not introduce a new required step. It simply delays when the built asset will be retrieved from the GitHub Container Registry when necessary. `postinstall` scripts should also be avoided entirely due to their significantly insecure nature (see #64543). Follow up to [61492], [61873], and [62021]. Reviewed by jorbin. Merges [62321] to the 7.0. Props jorbin, johnbillion, desrosj. Fixes #64874. See #64393, #64543. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62330 602fd350-edb4-49c9-b593-d223f7449a82
Reviewed by audrasjb, desrosj. Merges [62324] to the 7.0 branch. Props timse201, audrasjb, sanketparmar, jorbin, desrosj. Fixes #64984. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62331 602fd350-edb4-49c9-b593-d223f7449a82
Force wp_is_collaboration_enabled() to always return false, remove the Collaboration control from Writing Settings, and stop accepting that option via options.php. Use wp_is_collaboration_enabled() for admin post list and heartbeat lock checks so UI matches the disabled collaboration API. Co-authored-by: Cursor <cursoragent@cursor.com>
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This effectively removes RTC from WP 7 without actually removing the code. This keeps us from making a lot of changes late in the release process and leaves the code in place which will be needed later anyways.
AI assistance: Yes
Tool(s): Cursor,
Model(s): Opus 4.6
Used for: All of it