Skip to content

Menus: Add wp_nav_menus_registered filter to get_registered_nav_menus() - #12559

Open
SainathPoojary wants to merge 3 commits into
WordPress:trunkfrom
SainathPoojary:fix/31391
Open

Menus: Add wp_nav_menus_registered filter to get_registered_nav_menus()#12559
SainathPoojary wants to merge 3 commits into
WordPress:trunkfrom
SainathPoojary:fix/31391

Conversation

@SainathPoojary

Copy link
Copy Markdown

Trac ticket: #31391

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@SainathPoojary
SainathPoojary marked this pull request as ready for review July 17, 2026 12:55
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sainathpoojary.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copilot AI review requested due to automatic review settings July 23, 2026 15:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new wp_nav_menus_registered filter so plugins/themes can modify the array returned by get_registered_nav_menus(), and adds PHPUnit coverage to verify the filter is applied and can reorder/remove locations.

Changes:

  • Added wp_nav_menus_registered filter to get_registered_nav_menus() output.
  • Added new PHPUnit tests validating the filter can remove and reorder registered menu locations.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/wp-includes/nav-menu.php Applies the new wp_nav_menus_registered filter when returning registered nav menu locations.
tests/phpunit/tests/menu/registeredNavMenus.php Adds tests ensuring the filter is applied and can reorder/remove locations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/wp-includes/nav-menu.php Outdated
Comment on lines +159 to +162
* @param string[] $menus Associative array of registered navigation menu descriptions
* keyed by their location. If none are registered, an empty array.
*/
return apply_filters( 'wp_nav_menus_registered', $menus );
Comment on lines +9 to +17
class Tests_Menu_RegisteredNavMenus extends WP_UnitTestCase {

/**
* Tear down after each test.
*/
public function tear_down() {
remove_all_filters( 'wp_nav_menus_registered' );
parent::tear_down();
}
Copilot AI review requested due to automatic review settings July 23, 2026 15:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants