Filesystem API: Fix inaccurate WP_Filesystem_Direct::chmod() file permissions comparison#12648
Filesystem API: Fix inaccurate WP_Filesystem_Direct::chmod() file permissions comparison#12648jeremyfelt wants to merge 1 commit into
WP_Filesystem_Direct::chmod() file permissions comparison#12648Conversation
…ermissions comparison The use of `| 0644` alters the permission bits read from the file to a minimum floor before comparing them with the requested mode. This results in an inaccurate comparison. Removing this allows the `& 0777` mask to perform as intended: strip the filetype bits from the value returned by `fileperms( $file )` so that the current permission bits can be used for comparison with the requested mode. This was added during review as part of #64610 for consistency with other parts of core, but those are using `| 0755` and `| 0644` to ensure `FS_CHMOD_DIR` and `FS_CHMOD_FILE` are set with the minimum permission bits required.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The use of
| 0644alters the permission bits read from the file to a minimum floor before comparing them with the requested mode.This results in an inaccurate comparison.
Removing this allows the
& 0777mask to perform as intended: strip the filetype bits from the value returned byfileperms( $file )so that the current permission bits can be used for comparison with the requested mode.This was added during review as part of #64610 for consistency with other parts of core, but those are using
| 0755and| 0644to ensureFS_CHMOD_DIRandFS_CHMOD_FILEare set with the minimum permission bits required.Trac ticket: https://core.trac.wordpress.org/ticket/65695
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Opus 4.8
Used for: Code review
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.