Skip to content

Filesystem API: Fix inaccurate WP_Filesystem_Direct::chmod() file permissions comparison#12648

Open
jeremyfelt wants to merge 1 commit into
WordPress:trunkfrom
jeremyfelt:task/fix-filesystem-chmod
Open

Filesystem API: Fix inaccurate WP_Filesystem_Direct::chmod() file permissions comparison#12648
jeremyfelt wants to merge 1 commit into
WordPress:trunkfrom
jeremyfelt:task/fix-filesystem-chmod

Conversation

@jeremyfelt

Copy link
Copy Markdown
Member

The use of | 0644 alters the permission bits read from the file to a minimum floor before comparing them with the requested mode.

This results in an inaccurate comparison.

Removing this allows the & 0777 mask to perform as intended: strip the filetype bits from the value returned by fileperms( $file ) so that the current permission bits can be used for comparison with the requested mode.

This was added during review as part of #64610 for consistency with other parts of core, but those are using | 0755 and | 0644 to ensure FS_CHMOD_DIR and FS_CHMOD_FILE are set with the minimum permission bits required.

Trac ticket: https://core.trac.wordpress.org/ticket/65695

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Opus 4.8
Used for: Code review


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…ermissions comparison

The use of `| 0644` alters the permission bits read from the file
to a minimum floor before comparing them with the requested mode.

This results in an inaccurate comparison.

Removing this allows the `& 0777` mask to perform as intended: strip
the filetype bits from the value returned by `fileperms( $file )` so
that the current permission bits can be used for comparison with the
requested mode.

This was added during review as part of #64610 for consistency with
other parts of core, but those are using `| 0755` and `| 0644` to
ensure `FS_CHMOD_DIR` and `FS_CHMOD_FILE` are set with the minimum
permission bits required.
Copilot AI review requested due to automatic review settings July 22, 2026 21:03
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jeremyfelt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jeremyfelt
jeremyfelt requested review from SergeyBiryukov and removed request for Copilot July 22, 2026 21:03
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant