Administration: Make the Community Events "requires JavaScript" notice translatable#12680
Administration: Make the Community Events "requires JavaScript" notice translatable#12680mukeshpanchal27 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Makes the Community Events “requires JavaScript” fallback notice in the Events & News dashboard widget translatable by ensuring the string is passed through core i18n.
Changes:
- Wrap the “This widget requires JavaScript.” notice string in
__()insidewp_print_community_events_markup()so it can be translated.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
@mukeshpanchal27 Thanks, Though I have addressed this as a part of this PR - https://github.com/WordPress/wordpress-develop/pull/12677/changes 😅 |
I missed that. 😄 Let's keep the translation fix in this PR since I opened a dedicated ticket for it. your PR seems to be expanding the scope, so I'd suggest handling only the translation issue here and keeping the WDYT? |
Makes sense, let's fix the translation issue with this ticket. I will update the my PR once this get's merged to trunk. 👍 |
Trac ticket: https://core.trac.wordpress.org/ticket/65705
The no-JavaScript fallback notice in
wp_print_community_events_markup()wrapped its string in bare parentheses instead of__(), so the message was never sent through translation:Use of AI Tools
N/A
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.