Build/test tools: forward multisite settings in the fork test matrix to improve CI efficiency#12693
Conversation
The `limited-matrix-for-forks` job declares multisite include rows but does not forward `multisite` or `phpunit-config` to the reusable workflow. Those rows therefore run single-site and duplicate existing single-site coverage instead of exercising multisite. Forward both inputs so the multisite rows select `tests/phpunit/multisite.xml`, matching the `test-with-mysql`, `test-with-mariadb`, and innovation-release callers.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Pull request overview
This PR fixes the fork-only PHPUnit workflow matrix so that multisite matrix rows actually run as multisite when calling the reusable PHPUnit workflow, restoring the intended coverage without increasing job count.
Changes:
- Forward
multisitefrom thelimited-matrix-for-forksjob matrix into the reusable workflow inputs. - Forward
phpunit-config, selectingtests/phpunit/multisite.xmlwhenmultisiteis enabled (otherwisephpunit.xml.dist), aligning behavior with other PHPUnit workflow callers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
For reviewers: this PR changes the It forwards |
Trac ticket
https://core.trac.wordpress.org/ticket/65712
What
The
limited-matrix-for-forksjob inphpunit-tests.ymldeclares multisite include rows but never forwardsmultisiteorphpunit-configto the reusable workflow. Those rows fall back to single-site defaults, so each one duplicates an existing single-site job instead of exercising multisite.This forwards both inputs so the multisite rows select
tests/phpunit/multisite.xml, matching thetest-with-mysql,test-with-mariadb, and innovation-release callers.Why
The fork matrix currently spends jobs on duplicate single-site runs and skips the multisite coverage it intends to provide. The fix restores that coverage without adding or removing any jobs.
Expected impact
Scope: the
limited-matrix-for-forksjob only. It runs on personal forks outside theWordPress/organization, so the canonical matrices are untouched.multisite: truerows now loadtests/phpunit/multisite.xml.A healthy run shows three jobs configured with
tests/phpunit/multisite.xmland no increase in total job count.Definition of done
A reviewer can validate and verify the change as follows:
multisiteandphpunit-configinlimited-matrix-for-forksonly, matching thetest-with-mysqlcaller.actionlintpasses onphpunit-tests.yml.tests/phpunit/multisite.xmlas the PHPUnit config; the single-site jobs still showphpunit.xml.dist.test-with-mysql,test-with-mariadb, ortest-innovation-releases.Testing
actionlintpasses on the changed workflow.tests/phpunit/multisite.xml; single-site rows are unchanged.WordPress/organization, so it does not affect the canonical CI.