Skip to content

Speed up register_core_block_style_handles() $register_style check - #12802

Open
josephscott wants to merge 1 commit into
WordPress:trunkfrom
josephscott:65779/blocks-register-style
Open

Speed up register_core_block_style_handles() $register_style check#12802
josephscott wants to merge 1 commit into
WordPress:trunkfrom
josephscott:65779/blocks-register-style

Conversation

@josephscott

Copy link
Copy Markdown
Contributor

https://core.trac.wordpress.org/ticket/65779

AI assistance: Yes
Tool(s): Claude
Model(s): Opus 5
Used for: Exploration, validating ideas for improvement, and writing the tests
-->


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props josephscott, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible can you share the performance number?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the original ticket: https://core.trac.wordpress.org/ticket/65779#comment:1

I confirmed that this speeds up register_core_block_style_handles() on my local WordPress 7.0.2 release. I tested by adding hrtime() to the stop and bottom of that function and writing the result with error_log(). Then I requested the Hello World post. This was M5 Macbook Pro.

Median for 10 runs with current is_array() code: 2.434125 ms
Median for 10 runs with isset() code: 1.352646 ms

That is a 44% reduction in how long register_core_block_style_handles() takes to finish. It hooks into init so it runs early and often.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for sharing 🙌

@mukeshpanchal27

Copy link
Copy Markdown
Member

Additional props for folks who works on 12798

Props khokansardar, irozum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants