Skip to content

Media: Register the wp-media-utils style handle. - #12813

Open
t-hamano wants to merge 1 commit into
WordPress:trunkfrom
t-hamano:65794-media-utils-style-handle
Open

Media: Register the wp-media-utils style handle.#12813
t-hamano wants to merge 1 commit into
WordPress:trunkfrom
t-hamano:65794-media-utils-style-handle

Conversation

@t-hamano

@t-hamano t-hamano commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Before

image

After

Note that the layout of the Author field has been corrected.

image

Trac ticket: https://core.trac.wordpress.org/ticket/65794

Use of AI Tools

Used for: Initial code skeleton and test suggestions; final implementation and tests were reviewed and edited by me.

The `@wordpress/media-utils` package ships a stylesheet that is built into
`wp-includes/css/dist/media-utils/`, but no matching style handle was
registered. As a result the styles for the media editing modal provided by
the package were never enqueued and the modal rendered unstyled.

Register `wp-media-utils` alongside the other package styles, add it to the
RTL-enabled handles, and make `wp-edit-post` depend on it so the modal is
styled wherever the block editor loads it.

See #65794.
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@t-hamano
t-hamano marked this pull request as ready for review August 3, 2026 11:25
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks, softglaze.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@softglazee

Copy link
Copy Markdown

I tested this branch locally at commit 489b105139. The wp-media-utils-css stylesheet is now correctly registered and enqueued on both post-new.php and site-editor.php. The Network tab confirms the file returns a 200 OK status.

@andrewserong andrewserong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you for fixing this! Also a good one for us to keep in mind if/when we ever roll out the media cropper to other screens in future releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants