Skip to content

Media Library: Strip additional parameters out of search #12839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanielHudson2 wants to merge 2 commits into
base: trunk
Choose a base branch
from
+50 −46
Open

Media Library: Strip additional parameters out of search #12839

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fb7782
Media Library: Strip additional parameters out of search
DanielHudson2 Aug 4, 2026
82c7481
Media Library: Use search url parameter rather than backbone route to…
DanielHudson2 Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 50 additions & 46 deletions src/js/media/routers/manage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,60 +8,64 @@
* @class
* @augments Backbone.Router
*/
var Router = Backbone.Router.extend(/** @lends wp.media.view.MediaFrame.Manage.Router.prototype */{
routes: {
'upload.php?item=:slug&mode=edit': 'editItem',
'upload.php?item=:slug': 'showItem',
'upload.php?search=:query': 'search',
'upload.php': 'reset'
},
var Router = Backbone.Router.extend(
/** @lends wp.media.view.MediaFrame.Manage.Router.prototype */ {
routes: {
'upload.php?item=:slug&mode=edit': 'editItem',
'upload.php?item=:slug': 'showItem',
'upload.php?search=:query': 'search',
'upload.php': 'reset',
},

// Map routes against the page URL.
baseUrl: function( url ) {
return 'upload.php' + url;
},
// Map routes against the page URL.
baseUrl: function ( url ) {
return 'upload.php' + url;
},

reset: function() {
var frame = wp.media.frames.edit;
reset: function () {
var frame = wp.media.frames.edit;

if ( frame ) {
frame.close();
}
},
if ( frame ) {
frame.close();
}
},

// Respond to the search route by filling the search field and triggering the input event.
search: function( query ) {
jQuery( '#media-search-input' ).val( query ).trigger( 'input' );
},
// Respond to the search route by filling the search field and triggering the input event.
search: function () {
var params = new URLSearchParams( window.location.search );
var query = params.get( 'search' ) || '';
jQuery( '#media-search-input' ).val( query ).trigger( 'input' );
},

// Show the modal with a specific item.
showItem: function( query ) {
var media = wp.media,
frame = media.frames.browse,
library = frame.state().get('library'),
item;
// Show the modal with a specific item.
showItem: function ( query ) {
var media = wp.media,
frame = media.frames.browse,
library = frame.state().get( 'library' ),
item;

// Trigger the media frame to open the correct item.
item = library.findWhere( { id: parseInt( query, 10 ) } );
// Trigger the media frame to open the correct item.
item = library.findWhere( { id: parseInt( query, 10 ) } );

if ( item ) {
item.set( 'skipHistory', true );
frame.trigger( 'edit:attachment', item );
} else {
item = media.attachment( query );
frame.listenTo( item, 'change', function( model ) {
frame.stopListening( item );
frame.trigger( 'edit:attachment', model );
} );
item.fetch();
}
},
if ( item ) {
item.set( 'skipHistory', true );
frame.trigger( 'edit:attachment', item );
} else {
item = media.attachment( query );
frame.listenTo( item, 'change', function ( model ) {
frame.stopListening( item );
frame.trigger( 'edit:attachment', model );
} );
item.fetch();
}
},

// Show the modal in edit mode with a specific item.
editItem: function( query ) {
this.showItem( query );
wp.media.frames.edit.content.mode( 'edit-details' );
// Show the modal in edit mode with a specific item.
editItem: function ( query ) {
this.showItem( query );
wp.media.frames.edit.content.mode( 'edit-details' );
},
}
});
);

module.exports = Router;
Loading