Skip to content

Improve workflow logic checks for private repos #12939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
desrosj wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Improve workflow logic checks for private repos #12939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions .github/workflows/coding-standards.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,29 @@ jobs:
uses: ./.github/workflows/reusable-coding-standards-php.yml
permissions:
contents: read
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
if: |
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)

# Runs the JavaScript coding standards checks.
jshint:
name: Coding standards
uses: ./.github/workflows/reusable-coding-standards-javascript.yml
permissions:
contents: read
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
if: |
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)

slack-notifications:
name: Slack Notifications
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/end-to-end-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,14 @@ jobs:
uses: ./.github/workflows/reusable-end-to-end-tests.yml
permissions:
contents: read
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
if: |
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)
strategy:
fail-fast: false
matrix:
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/javascript-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,14 @@ jobs:
uses: ./.github/workflows/reusable-javascript-tests.yml
permissions:
contents: read
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
if: |
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)

slack-notifications:
name: Slack Notifications
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/javascript-type-checking.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,14 @@ jobs:
uses: ./.github/workflows/reusable-javascript-type-checking-v1.yml
permissions:
contents: read
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
if: |
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)

slack-notifications:
name: Slack Notifications
Expand Down
12 changes: 11 additions & 1 deletion .github/workflows/performance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,17 @@ jobs:
determine-matrix:
name: Determine Matrix
runs-on: ubuntu-24.04
if: ${{ ( github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' ) && ! contains( github.event.before, '00000000' ) }}
if: |
(
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)
) &&
! contains( github.event.before, '00000000' )
permissions:
actions: read
env:
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/php-compatibility.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,14 @@ jobs:
uses: ./.github/workflows/reusable-php-compatibility.yml
permissions:
contents: read
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
if: |
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)

slack-notifications:
name: Slack Notifications
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/phpstan-static-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,14 @@ jobs:
uses: ./.github/workflows/reusable-phpstan-static-analysis-v1.yml
permissions:
contents: read
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
if: |
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)

slack-notifications:
name: Slack Notifications
Expand Down
61 changes: 55 additions & 6 deletions .github/workflows/phpunit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,14 @@ jobs:
uses: ./.github/workflows/reusable-prepare-gutenberg.yml
permissions:
contents: read
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
if: |
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)

#
# Creates a PHPUnit test job for each PHP/MySQL combination.
Expand All @@ -82,7 +89,16 @@ jobs:
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
WPT_REPORT_API_KEY: ${{ secrets.WPT_REPORT_API_KEY }}
if: ${{ startsWith( github.repository, 'WordPress/' ) && ( github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' ) }}
if: |
startsWith( github.repository, 'WordPress/' ) && (
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)
)
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -165,7 +181,16 @@ jobs:
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
WPT_REPORT_API_KEY: ${{ secrets.WPT_REPORT_API_KEY }}
if: ${{ startsWith( github.repository, 'WordPress/' ) && ( github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' ) }}
if: |
startsWith( github.repository, 'WordPress/' ) && (
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)
)
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -223,7 +248,16 @@ jobs:
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
WPT_REPORT_API_KEY: ${{ secrets.WPT_REPORT_API_KEY }}
if: ${{ startsWith( github.repository, 'WordPress/' ) && ( github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' ) }}
if: |
startsWith( github.repository, 'WordPress/' ) && (
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)
)
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -270,7 +304,16 @@ jobs:
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
WPT_REPORT_API_KEY: ${{ secrets.WPT_REPORT_API_KEY }}
if: ${{ startsWith( github.repository, 'WordPress/' ) && ( github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' ) }}
if: |
startsWith( github.repository, 'WordPress/' ) && (
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)
)
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -304,7 +347,13 @@ jobs:
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
WPT_REPORT_API_KEY: ${{ secrets.WPT_REPORT_API_KEY }}
if: ${{ ! startsWith( github.repository, 'WordPress/' ) && github.event_name == 'pull_request' }}
if: |
! startsWith( github.repository, 'WordPress/' ) &&
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
strategy:
fail-fast: false
matrix:
Expand Down
18 changes: 16 additions & 2 deletions .github/workflows/test-and-zip-default-themes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,14 @@ jobs:
permissions:
contents: read
timeout-minutes: 10
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
if: |
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -119,7 +126,14 @@ jobs:
permissions:
contents: read
timeout-minutes: 10
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
if: |
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)
strategy:
fail-fast: false
matrix:
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/test-build-processes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,14 @@ jobs:
uses: ./.github/workflows/reusable-test-core-build-process.yml
permissions:
contents: read
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
if: |
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)
strategy:
fail-fast: false
matrix:
Expand Down
20 changes: 18 additions & 2 deletions .github/workflows/upgrade-develop-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,16 @@ jobs:
build:
name: Build
uses: ./.github/workflows/reusable-build-package.yml
if: ${{ startsWith( github.repository, 'WordPress/' ) && ( github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' ) }}
if: |
startsWith( github.repository, 'WordPress/' ) && (
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)
)
permissions:
contents: read

Expand Down Expand Up @@ -87,7 +96,14 @@ jobs:
upgrade-tests-develop-forks:
name: Upgrade from ${{ matrix.wp }}
uses: ./.github/workflows/reusable-upgrade-testing.yml
if: ${{ github.repository != 'WordPress/wordpress-develop' }}
# This job also runs for the push event, which has no draft state to check.
if: |
github.repository != 'WordPress/wordpress-develop' && (
github.event_name != 'pull_request' ||
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
needs: [ build ]
permissions:
contents: read
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/workflow-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,14 @@ jobs:
lint:
name: Lint GitHub Action files
uses: ./.github/workflows/reusable-workflow-lint.yml
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
if: |
github.repository == 'WordPress/wordpress-develop' || (
github.event_name == 'pull_request' && (
! github.event.repository.private ||
! github.event.pull_request.draft ||
contains( github.event.pull_request.labels.*.name, 'Draft Workflow Runs' )
)
)
permissions:
security-events: write
actions: read
Expand Down
Loading