Skip to content

51292 ensure published posts have cats - #527

Closed
peterwilsoncc wants to merge 12 commits into
WordPress:masterfrom
peterwilsoncc:51292-ensure-published-posts-have-cats
Closed

51292 ensure published posts have cats#527
peterwilsoncc wants to merge 12 commits into
WordPress:masterfrom
peterwilsoncc:51292-ensure-published-posts-have-cats

Conversation

@peterwilsoncc

Copy link
Copy Markdown
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/51292

This also includes the unit tests that will be required for scaling term counts but they probably should have existed all along and I couldn't find any that did.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@peterwilsoncc
peterwilsoncc force-pushed the 51292-ensure-published-posts-have-cats branch from a19c77d to 6e3c475 Compare September 12, 2020 02:46
@TimothyBJacobs

Copy link
Copy Markdown
Member

Does this need to account for the new default_term argument for custom taxonomies or are they not affected?

@peterwilsoncc

Copy link
Copy Markdown
Contributor Author

@TimothyBJacobs Nice catch, they are also affected. Further changes to come.

@peterwilsoncc

Copy link
Copy Markdown
Contributor Author

@TimothyBJacobs It does now, see 7c9a69b -- any further thought would be welcome.

Comment thread src/wp-includes/post.php Outdated
@peterwilsoncc
peterwilsoncc deleted the 51292-ensure-published-posts-have-cats branch September 19, 2020 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants