Update precommit:emoji script after GitHub's sunset of SVN#6107
Update precommit:emoji script after GitHub's sunset of SVN#6107desrosj wants to merge 12 commits intoWordPress:trunkfrom
precommit:emoji script after GitHub's sunset of SVN#6107Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Tested. Only thing I ran into was permission needing updating on the shell script. Submitted a PR to add that via desrosj#153 |
Update file permissions for the shell script
|
Thanks @kraftbj! I've merged that. To bring a brief summary here, here are a few things I don't love about the current implementation (though not strongly opposed to):
|
|
I don't love adding I tried to make it all part of the Grunt JS file in desrosj#154 -- can you give that a spin? |
Add script directly to Gruntfile.js
|
Thanks all for keeping this going! I think we're at a good spot. There's just one outstanding question about what seems like an unintentional deleted line. |
|
I concur. If the deletion was intentional (I'm not sure why it would be), it should be noted in the commit to explain the connection. But, with that line restored, LGTM. |
6f2e0ea to
e57fef2
Compare
This reverts commit 6477e5f.
|
It was me that removed that line, wasn't it? Just realized that looking through this again. 🙃 Since I can't recall why I included that, or see a reason how it's related, I've gone and removed it. I also added a new step to the Actions workflow that tests our build process to run the |
As the script currently reads the files from the |
This prevents upstream changes from breaking our test scripts.
| # Tests the WordPress Core build process on multiple operating systems. | ||
| test-core-build-process: | ||
| name: Core running from ${{ matrix.directory }} | ||
| uses: WordPress/wordpress-develop/.github/workflows/callable-test-core-build-process.yml@trunk |
I've tested using a tag reference instead of branch, and it seems to work alright. Talked through this a bit in Slack with @peterwilsoncc and since this adds an additional spot to update when updating the library, it would be nice to automate it a bit. |
All build script related changes form #5804 have been copied over.
Trac ticket: https://core.trac.wordpress.org/ticket/60520
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.