Add script directly to Gruntfile.js#154
Merged
desrosj merged 1 commit intodesrosj:update/precommit-emojifrom Feb 26, 2024
Merged
Add script directly to Gruntfile.js#154desrosj merged 1 commit intodesrosj:update/precommit-emojifrom
desrosj merged 1 commit intodesrosj:update/precommit-emojifrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
peterwilsoncc
approved these changes
Feb 16, 2024
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
I've tested this and it works for me on macOS. Very nice, thank you.
Testing notes:
- Replace arrays in
src/wp-includes/formatting.phpwith empty arrays. - Run the precommit script with this branch applied
- Run
test_wp_emoji_list_returns_datatest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this work for you? It seems to work for me.