Plugin Directory: Tidy up Block Plugin Checker output and add tests#725
Closed
obenland wants to merge 2 commits into
Closed
Plugin Directory: Tidy up Block Plugin Checker output and add tests#725obenland wants to merge 2 commits into
obenland wants to merge 2 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Escape checker result values (readme/header license, block names, file paths) consistently at the point they are built into messages, and add a kses backstop when the block validator renders them. Apply the readme parser's existing sanitize_text() to the License header so it matches the other headers. Also make get_browser_url() return a string when there is no repo, guard an undefined array key in the results loop, tidy an inconsistent esc_html() call in the readme validator, and make the local page seed idempotent. Adds Block_Plugin_Checker_Test covering the individual checks and message rendering. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UNnLdnE7etihGNvsWY1qGE
…y-up. Follow-up to 78e1c8d. Coding standards: * Add the missing `@return` to `get_browser_url()`, whose contract changed from an implicit null to ''. * Add `translators:` comments and order the placeholders on the strings this branch touched. * Drop trailing whitespace from the lines this branch added. Local env: * `ensure_page()` now checks wp-cli's exit status and fails loudly instead of reporting success for an environment it never seeded. Assigning before piping into `tr` keeps the status from being masked by the pipeline. * Reconcile title and parent, not just content, so a page left over from an earlier run is corrected rather than topped up. * `--posts_per_page=1` stops a slug collision concatenating two IDs. * Restore per-page progress output, on stderr so stdout stays the ID channel. * Correct the rationale comment: `wp post create` suffixes the *new* post, leaving the canonical page with its original content. Output: * `bin/check-block.php` decodes entities and strips markup, so the CLI checker no longer prints "GPLv2 & MIT" to a terminal. Tests: * Declare `@group block-validator` as `#[Group]`. PHPUnit 11 ignores a class doc-block once the class carries any attribute, so `--group block-validator` matched zero tests. Same one-line fix for the translation test. * Cover `run_check_plugin_repo()` escaping across its rejection branches, the `get_browser_url()` empty-string contract, and the block.json `wp_kses()` allowlist, which was previously exercised with a markup-free fixture. * Add a regression guard that escaping stays idempotent: esc_html() over an already-sanitized license must not produce `&amp;`. * Drop an overfit quote-count assertion and correct docblocks that described behavior the code does not have. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UNnLdnE7etihGNvsWY1qGE
obenland
force-pushed
the
update/block-plugin-checker-output
branch
from
July 21, 2026 16:16
09a9843 to
f3c7624
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cleanup pass over the Block Plugin Checker (the
/developers/block-plugin-validator/tool), plus test coverage.Changes
License, block names, namespaces, and file paths. Escape each of those where it's interpolated (esc_html()for text,esc_url()for the Trac/GitHub links), and add a smallwp_kses()backstop inBlock_Validatorso only the markup the checks intentionally emit (<code>,<a>, …) survives rendering.sanitize_text()overname,short_description, and friends; apply it to theLicenseheader too (after the URL is split out, so the<https://…>autolink form still works).get_browser_url()now returns an empty string instead ofnullwhen there's no repo (e.g. a ZIP upload), avoiding a PHP 8 deprecation fromesc_url( null ).ignored_tagsmessage now escapes its data like its sibling cases.after-start.shpage seeding is now idempotent (it was creating a fresh duplicate page set on everywp-env start).Tests
Adds
Block_Plugin_Checker_Testcovering the individual checks (license, block tag, block name/namespace, block.json validity, PHP calls, single-parent) and message rendering, and extendsTest_Readme_Parserfor the license header. Full plugin-directory suite: 149 passing. New/changed files are clean under--standard=WordPress.🤖 Generated with Claude Code