Skip to content

docs(TextInput): Expand accessibility guidance for AI codegen - #4139

Merged
williamjstanton merged 7 commits into
Workday:a11yfrom
williamjstanton:william-aidocs-textinput
Aug 25, 2026
Merged

docs(TextInput): Expand accessibility guidance for AI codegen#4139
williamjstanton merged 7 commits into
Workday:a11yfrom
williamjstanton:william-aidocs-textinput

Conversation

@williamjstanton

Copy link
Copy Markdown
Collaborator

Summary

Expands TextInput Storybook Accessibility docs to the AI-codegen template used by FormField, Dialog, and TextArea, and makes small TextArea wording/prop-name sync fixes so the two stay consistent.

Release Category

Documentation


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

  1. modules/react/text-input/stories/TextInput.mdx — new Accessibility section (Minimum structure → Built-in Behaviors → Requirements → Anti-Patterns)
  2. Compare structure/wording against modules/react/text-area/stories/TextArea.mdx (shared skeleton; TextInput-only deltas for InputGroup, autoComplete, and type)
  3. Usage updates in TextInput (isRequired, Icons label-association note, icon role="presentation" note)

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Please focus on:

  • Accuracy of InputGroup + FormField wiring (FormField.Field as={InputGroup} + hoisted id)
  • Whether Built-in Behaviors vs Requirements vs Anti-Patterns split is clear for codegen
  • Parity with TextArea (lean Keyboard section; no redundant standard HTML bullets)

Testing Manually

  1. Run Storybook (yarn start) and open Components → Inputs → Text Input → Docs
  2. Confirm the Accessibility section renders (code blocks, tables, kbd, links)
  3. Spot-check cross-links: FormField Accessibility, TextArea, Icons / Ref Forwarding anchors, WCAG Identify Input Purpose
  4. Optionally open Text Area Docs and confirm shared section structure still matches

Screenshots or GIFs (if applicable)

N/A — documentation-only

sheelah and others added 4 commits August 7, 2026 10:24
Add-on to Workday#4100. Adds upgrade guide links to the README for v15 and v16 and a link to our older fonts package README in the fonts guide.

[category:Documentation]
Align TextInput with the FormField/TextArea Accessibility template and sync TextArea for shared wording consistency.

Co-authored-by: Cursor <cursoragent@cursor.com>
@williamjstanton
williamjstanton requested a review from a team as a code owner August 13, 2026 13:41
@williamjstanton williamjstanton added accessibility documentation Affects documentation ready for review Code is ready for review labels Aug 13, 2026
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)
  • support
  • prerelease/minor
  • prerelease/major

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 51d50736-b760-47b1-90b3-18b57bd15ff0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@purvas12 purvas12 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment in the Usage section for Text Input. Looks good to me otherwise.

Comment thread modules/react/text-input/stories/TextInput.mdx Outdated
@williamjstanton williamjstanton changed the title docs(text-input): expand accessibility guidance for AI codegen docs(TextInput): Expand accessibility guidance for AI codegen Aug 17, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
@cypress

cypress Bot commented Aug 17, 2026

Copy link
Copy Markdown

Workday/canvas-kit    Run #11539

Run Properties:  status check passed Passed #11539  •  git commit 4a7242d5b2 ℹ️: Merge ea1d710bd4937fb9d390c34c46b045e3f17249bd into b8ad758804ebe906bec1f925d922...
Project Workday/canvas-kit
Branch Review william-aidocs-textinput
Run status status check passed Passed #11539
Run duration 03m 08s
Commit git commit 4a7242d5b2 ℹ️: Merge ea1d710bd4937fb9d390c34c46b045e3f17249bd into b8ad758804ebe906bec1f925d922...
Committer William Stanton
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 17
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 812
View all changes introduced in this branch ↗︎
UI Coverage  19.51%
  Untested elements 1537  
  Tested elements 370  
Accessibility  99.47%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 72  

Co-authored-by: Cursor <cursoragent@cursor.com>
@williamjstanton
williamjstanton merged commit e3ae95a into Workday:a11y Aug 25, 2026
19 checks passed
@williamjstanton
williamjstanton deleted the william-aidocs-textinput branch September 2, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility documentation Affects documentation ready for review Code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants