CPLAT-12090 Only expect propType errors in DDC#104
Merged
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
+ Something in Dart core changed recently where a `DivElement` in minified JS used to be `DivElement:<div>` but is now `minified:jQ:<div>`.
Contributor
joebingham-wk
left a comment
joebingham-wk
left a comment
There was a problem hiding this comment.
The changes look great! They're nice and simple, and runningInDDC is dope. I had a couple small comments about tests, but that's it!
+ Instead of pinning the Dart SDK version
Contributor
joebingham-wk
left a comment
joebingham-wk
left a comment
There was a problem hiding this comment.
+1! I know there's a dependent PR, so I can formally approve once that's merged and the pubspec is clean. All the changes here look good to me though!
rmconsole3-wf
changed the title
corwinsheahan-wf
previously approved these changes
Sep 4, 2020
| @@ -0,0 +1,6 @@ | |||
| /// Returns whether the current runtime is `dartdevc`. | |||
| bool runningInDDC() { | |||
Contributor
There was a problem hiding this comment.
I wonder if we should just move this to a common location 🤷
greglittlefield-wf
requested changes
Sep 8, 2020
This reverts commit a3e29b2.
Contributor
Author
|
@Workiva/release-management-pp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An upcoming change to the
reactpackage will make it so thatpropTypesare not included in dart2js compiled output.These changes make it so that the
propTypestesting utilities never cause anexpectto fail in dart2js by conditionally utilizing theanythingMatcher when the runtime is dart2js. This is necessary in order to release the react-dart changes "safely" (e.g. without causing a bunch of suddenly failing dart2js tests for consumers).We will need to coordinate the release of that change in react-dart so that we release these changes in over_react_test immediately after.
Also in this changeset is a new utility function -
runningInDDC()- which has been found in a number of consumer repos (under a different name), so it made sense to export it from here with a new name to avoid conflicts.