CPLAT-11281 Only include propTypes in DDC output#258
Merged
Conversation
propTypes are a dev-only tool, so they should not be present in the compiled dart2js output sent to production.
+ This one slipped through the cracks. Should have been deprecated with the release of Component2
willdrach-wk
approved these changes
Jun 10, 2020
willdrach-wk
left a comment
willdrach-wk
left a comment
There was a problem hiding this comment.
lgtm, obviously would like someone else with more expertise to take a look
| if (isDDC()) { | ||
| test('', () { | ||
| expect(consoleErrorCalled, isTrue, reason: 'should have outputted a warning'); | ||
| expect(consoleErrorMessage, contains(expectedWarningPrefix)); |
There was a problem hiding this comment.
[nit] could this be a startsWith?
aaronlademann-wf
added a commit
to Workiva/over_react_test
that referenced
this pull request
Jul 22, 2020
# Conflicts: # lib/react_client.dart
# Conflicts: # lib/react.dart # lib/react_client.dart # test/util.dart
aaronlademann-wf
requested review from
corwinsheahan-wf,
greglittlefield-wf,
joebingham-wk,
smaifullerton-wk and
sydneyjodon-wk
…roptypes-only-in-ddc
corwinsheahan-wf
approved these changes
Sep 4, 2020
Collaborator
Author
|
Just FYI - the dev SDK travis build is failing e'where - it is unrelated to the changes in this PR. |
greglittlefield-wf
requested changes
Sep 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
propTypesare a dev-only tool that do nothing whenreact_dom_with_react_dom_prod.jsis utilized. That production build of react is most commonly used alongside a production deploy of Dart code compiled with dart2js.Currently, the
propTypesmaps remain in the dart2js output - adding unnecessary bulk to consumer module(s).Solution
Wrap the access to
Component2.propTypesin anassert()so that they are included in JS compiled using DDC, but not dart2js.Boy Scoutin'
registerComponent. This should have been deprecated whenComponentwas - but we missed it.