GCP apply issues - #1358
Merged
Merged
Conversation
Add roles/artifactregistry.editor and repository permissions to psoxy-constants, update getting-started docs, and backfill 0.6.0 CHANGELOG upgrade notes for default_labels and provider 7.x. Co-authored-by: Cursor <cursoragent@cursor.com>
Document 403 prereq fixes and org-policy networking workarounds separately from the existing vpc-access-egress removal case. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GCP deployment guidance and IAM prerequisites to reduce common terraform apply failures (especially around Artifact Registry + Cloud Functions Gen 2), and expands troubleshooting documentation for permissions and org-policy related errors.
Changes:
- Added Artifact Registry Editor to the bootstrap/predefined role list and added missing Artifact Registry permissions for initial apply/destroy scenarios.
- Expanded GCP troubleshooting documentation with common 403 permission-denied and org-policy networking failure cases.
- Added upgrade notes in
CHANGELOG.mdclarifying google provider 7.xdefault_labelsusage and Artifact Registry role requirements.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| infra/modules/psoxy-constants/main.tf | Adds Artifact Registry role + permissions; adjusts permission comments for apply/destroy requirements. |
| docs/gcp/troubleshooting.md | Adds new troubleshooting sections for permissions and org-policy Cloud Run networking failures. |
| docs/gcp/getting-started.md | Documents Artifact Registry Editor as a prerequisite role for Gen 2 deployments. |
| CHANGELOG.md | Adds/clarifies GCP upgrade notes for provider 7.x labels and Artifact Registry permissions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 2. `terraform init --upgrade` and `terraform apply` | ||
|
|
||
| You will likely see MANY changes. These are caused by the provider version difference and should be benign. The vast majority are label changes; we utilize the `default_labels` functionality in google provider `5.x` to label all the infra created by this configuration; | ||
| You will likely see MANY changes. These are caused by the provider version difference and should be benign. The vast majority are label changes; we utilize the `default_labels` functionality in the google provider `7.x` at the root `provider "google"` block to label all the infra created by this configuration; |
aperez-worklytics
approved these changes
Jul 29, 2026
aperez-worklytics
approved these changes
Jul 29, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.
Tip: disable this comment in your organization's Code Review settings.
Co-authored-by: aperez-worklytics <75276364+aperez-worklytics@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Change implications
CHANGELOG.md: GCP deployments for 0.6.0+ require the Artifact Registry Editor role; new troubleshooting docs cover permission and org-policy deploy failures.