[W.I.P] Memex.Link tooltip redesign.#421
Closed
digi0ps wants to merge 74 commits intoWorldBrain:feature/direct-linking-uifrom
Closed
[W.I.P] Memex.Link tooltip redesign.#421digi0ps wants to merge 74 commits intoWorldBrain:feature/direct-linking-uifrom
digi0ps wants to merge 74 commits intoWorldBrain:feature/direct-linking-uifrom
Conversation
- Renamed react/ to components/. - Added necessary images.
- Using the old design for now
- pageX/Y instead of clientX/Y to account for scroll. - openSettings instead of settings url.
- not too sure about some of the namings
…ng of fallback overlay
First stab on Git Flow implementation. Updates for next release go in here, rest of PR's go to develop. Release contains: - Feature: Excluding pages with terms and domains in search results. - Bug fixes (@poltak, can you add those here?)
- Renamed react/ to components/. - Added necessary images.
- Installed `babel-polyfill` to polyfill async/await. - Changed getURL function to support the lack of browser.extension API.
- Few minor style modifications.
- Also, few new design changes.
digi0ps
force-pushed
the
tooltip-redesign
branch
from
8345095 to
432ccff
Compare
poltak
force-pushed
the
feature/direct-linking-ui
branch
from
f6a688f to
8211d8d
Compare
poltak
force-pushed
the
feature/direct-linking-ui
branch
from
9602500 to
63cd3b2
Compare
Member
|
Closing in favour of #425 (all the same stuff there, just fixed up branch) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
direct-linking-ui@oliversauter