Memex.Link tooltip refactor.#547
Conversation
|
Whoohoo! Very, very cool :) Does this also prevent the tooltip popping up when clicking links? (Only happens on some pages, probably mostly SPAs.) Would be cool to get this in as soon as possible, would remove a lot of frustration. |
|
No I haven't prevented it popping up in links ( I haven't experienced it personally, maybe I will check in SPAs ). |
Loops over all the parent elements to check if it's an anchor element.
Previously, it was positioned on the mouse pointer's coords. Now uses the range's bounding rectangle to find the position.
|
I have made the tooltip align right below the selected text ( like how Medium does ). Works nicely in most of the scenarios. But in some (rare) scenarios, when we select large ranges of text, it goes below the viewport or off position. But do give it a try when you are free! |
|
Can you show me an example of which page, maybe a screencast? Thanks! |
Actually i like that it is under the mouse pointer much more, as i have a short distance to create an annotation/direct link. |
|
@oliversauter It fails to align itself properly in some comments in GH like here. |
|
Cool, that must be easy. I will do it. 👍 |


This prevents the tooltip from popping up if clicked on empty spaces or inside docs cells.