Skip to content

Add hack to allow users to still add annot comments, tags#723

Merged
blackforestboi merged 6 commits intomasterfrom
hotfix/sidebar-keydown-hack
Feb 23, 2019
Merged

Add hack to allow users to still add annot comments, tags#723
blackforestboi merged 6 commits intomasterfrom
hotfix/sidebar-keydown-hack

Conversation

@poltak
Copy link
Copy Markdown
Member

@poltak poltak commented Feb 21, 2019

@blackforestboi
Copy link
Copy Markdown
Member

thanks for getting this on so quickly. It works only partially so far.
When using it on Github with 's' (which would start searching) I can type the first character, but the focus is then set to the search bar and the next letter is then searched for.

Thats already an improvement, as before it would immediately jump to the search bar.
Maybe we can block every character from being propagated up, or set the focus back to the text field after each character?

@poltak poltak force-pushed the hotfix/sidebar-keydown-hack branch from a7deed0 to 7f1ea77 Compare February 21, 2019 04:08
@poltak
Copy link
Copy Markdown
Member Author

poltak commented Feb 21, 2019

Just updated that and it seems to behave on GH now.
Google maps still somehow doesn't work. There's probably less people annotating text there, though it means that there's probably other sites that it doesn't fix it on.

@blackforestboi
Copy link
Copy Markdown
Member

ok, will give it another test. Here is something I stumbled over where they talk about this issue on google maps: https://stackoverflow.com/questions/48893262/google-maps-does-not-relinquish-key-presses-to-input-in-shadow-dom

@poltak
Copy link
Copy Markdown
Member Author

poltak commented Feb 21, 2019

I saw that too, but it seems to be with the maps API rather than the actual website.

@blackforestboi
Copy link
Copy Markdown
Member

ah ok. Found another couple of interactions with the GitHub keyboard shortcuts.

? calls the help screen
and cmd+c/a/v/x cannot be used. Just ignores it.

- addresses #722
- overrides default `keydown` event handling in a hacky way, but it works from user POV which I feel is the main thing for now
- does this break anything?
@poltak poltak force-pushed the hotfix/sidebar-keydown-hack branch from 7f1ea77 to 20efb7e Compare February 21, 2019 05:00
@poltak
Copy link
Copy Markdown
Member Author

poltak commented Feb 21, 2019

and cmd+c/a/v/x cannot be used. Just ignores it.

That should be fixed.

? calls the help screen

For whatever reason I can't get it to work for the question mark :S

I also added a commit to remove the sentry setup from the content script. It was capturing errors that happened on any random website and sending them to our sentry server. Maybe there's a way to detect our own errors we can implement later.

@blackforestboi blackforestboi merged commit cdaeb8c into master Feb 23, 2019
@blackforestboi
Copy link
Copy Markdown
Member

Merging this to be ready for release.

poltak added a commit that referenced this pull request Feb 25, 2019
digi0ps pushed a commit that referenced this pull request Feb 25, 2019
@blackforestboi blackforestboi deleted the hotfix/sidebar-keydown-hack branch June 22, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants