Add hack to allow users to still add annot comments, tags#723
Add hack to allow users to still add annot comments, tags#723blackforestboi merged 6 commits intomasterfrom
Conversation
|
thanks for getting this on so quickly. It works only partially so far. Thats already an improvement, as before it would immediately jump to the search bar. |
a7deed0 to
7f1ea77
Compare
|
Just updated that and it seems to behave on GH now. |
|
ok, will give it another test. Here is something I stumbled over where they talk about this issue on google maps: https://stackoverflow.com/questions/48893262/google-maps-does-not-relinquish-key-presses-to-input-in-shadow-dom |
|
I saw that too, but it seems to be with the maps API rather than the actual website. |
|
ah ok. Found another couple of interactions with the GitHub keyboard shortcuts. ? calls the help screen |
- addresses #722 - overrides default `keydown` event handling in a hacky way, but it works from user POV which I feel is the main thing for now - does this break anything?
7f1ea77 to
20efb7e
Compare
That should be fixed.
For whatever reason I can't get it to work for the question mark :S I also added a commit to remove the sentry setup from the content script. It was capturing errors that happened on any random website and sending them to our sentry server. Maybe there's a way to detect our own errors we can implement later. |
|
Merging this to be ready for release. |
keydownevent handling in a hacky way, but it seems to make things work again from user POV which I feel is the main thing for now