call import_array statically for linux/mac - #401
Merged
Conversation
Member
Author
|
this resolves the segfault in the "repaired" wheel, but it doesn't resolve the reason for the repair leading to the segfault |
Member
|
Segfault is still creeping around apparently (see Travis logs) |
Member
Author
I hope this isn't the same thing that is affecting windows with 3.7 edit: although segfaults are much easier to diagnose on linux so maybe this is a good thing? Edit 2.0: |
MaryanMorel
approved these changes
Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #400 and #397