[examples] chore: drop private-fork migration comments from DPPO teacher configs - #201
Merged
Jayce-Ping merged 1 commit intoJul 3, 2026
Merged
Conversation
…her configs Remove the "# DPPO teacher config migrated from private flow_dppo/<name>.yaml." and "# Mapping: grpo + mask_type: kl_adv -> dppo + kl_mask_type: v-based; kl_beta=0." header lines from all three teacher configs. These referenced the private fork and are no longer needed; each file header now keeps only the # Checkpoint: <url> line and the one-line training summary. Consistent with the earlier repo-wide private-fork reference scrub.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes remaining private-fork migration/mapping header comments from the DPPO teacher example configs, keeping the published checkpoint link and the one-line training summary so the configs remain self-describing without referencing the private fork.
Changes:
- Deleted two private-fork migration/mapping comment lines from each of the three DPPO teacher YAML headers.
- Preserved the
# Checkpoint: ...and training-summary header comments (no YAML keys/values changed).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| examples/dppo/lora/sd3_5/pickscore_teacher.yaml | Removes private-fork migration/mapping header comments; keeps public checkpoint + summary. |
| examples/dppo/lora/sd3_5/ocr_teacher.yaml | Removes private-fork migration/mapping header comments; keeps public checkpoint + summary. |
| examples/dppo/lora/sd3_5/geneval_teacher.yaml | Removes private-fork migration/mapping header comments; keeps public checkpoint + summary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #200. Removes the two private-fork migration/mapping header comment lines from all three DPPO teacher configs:
# DPPO teacher config migrated from private flow_dppo/<name>.yaml.# Mapping: grpo + mask_type: kl_adv -> dppo + kl_mask_type: v-based; kl_beta=0.Each file header now keeps only:
# Checkpoint: <url>— the published HuggingFace teacher LoRA# Trains SD3.5-Medium LoRA on dataset/<name> with <reward> reward (...)— one-line training summaryThis scrubs the remaining private-fork reference from the configs, consistent with the earlier repo-wide private-fork reference cleanup. No YAML keys or values are changed — comment-only.
Test plan
git diffconfirms exactly 2 lines removed per file (6 deletions total), comment-only.Arguments.load_from_yaml(trainer_type='dppo',run_nameintact).