779: process triggers for all question types #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in xls2json there are some code blocks that process specific question types, with a `continue` to the next row at the end of most blocks. But since the trigger processing code was placed after those blocks, it wasn't being done for question types with a block. Now the trigger processing is placed before those blocks. The issue resulted in the nested setvalue element not being added to the body control. - also adds test coverage for parsing comma + space scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #779
Addresses test coverage feedback in #776
Why is this the best possible solution? Were any other approaches considered?
In xls2json there are some code blocks that process specific question types, with a
continueto the next row at the end of most blocks. But since the trigger processing code was placed after those blocks, it wasn't being done for question types with a block. Now the trigger processing is placed before those blocks. The issue resulted in the nested setvalue element not being added to the body control.Also adds test coverage for parsing comma + space scenarios
What are the regression risks?
Fixes a regression. It's possible that external code is calling the builder class without providing processed trigger references, so for that scenario a check/error was added to avoid iterating the unprocessed string (as occurred for the #779 bug).
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code