test: Add test for account objects - #7625
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7625 +/- ##
=========================================
- Coverage 82.3% 82.3% -0.0%
=========================================
Files 1024 1024
Lines 78459 78459
Branches 8975 8975
=========================================
- Hits 64569 64558 -11
- Misses 13881 13892 +11
Partials 9 9 see 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
| seqs.reserve(numEntries); | ||
| for ([[maybe_unused]] auto _ : std::ranges::iota_view{0, numEntries}) | ||
| { | ||
| json::Value params; |
There was a problem hiding this comment.
can we add calls to testcase() to describe what each section is testing which rpc command?
There was a problem hiding this comment.
Could you please explain what you mean? The whole test is one test case, we just do a lot of rpc calls.
There was a problem hiding this comment.
Ah okay, I thought you were using different rpc commands but it seems that those for loops are for setting things up? If that's the case, then I think it's worth adding some comments.
Another thing is that we're using the submit command directly, but there's already tools like offer(Account, Amount, Amount)) which you can find them in Offer_test.cpp
| void | ||
| testAccountObjectDoesntShowCancelledOffers() | ||
| { | ||
| testcase("AccountObjectDoesntShowCancelledOffers"); |
There was a problem hiding this comment.
This test case name doesn't seem to be very human-readable.
2af88c9 to
6b88304
Compare
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
2 participants
High Level Overview of Change
Add a test case for account objects checking it doesn't show cancelled offers.
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)