Remove Invoke env and desktop wrapper#134
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the top-level Invoke.env mechanism and the desktop wrapper binary, shifting runtime environment configuration to Xray-core’s root env config and simplifying build artifacts. It also adds a hard cap to reject oversized Invoke requests/responses.
Changes:
- Remove
Invoke.envfrom the request model and delete the desktop wrapper build/output paths. - Add a 16 MiB size limit for Invoke requests and responses, with tests covering the new behavior.
- Pin Xray-core (and indirect deps) to a newer pseudo-version tied to the required main commit.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
readme/README.zh_CN.md |
Updates Chinese docs to remove wrapper/env guidance and point env config to Xray-core root config. |
README.md |
Updates English docs to remove wrapper/env guidance and point env config to Xray-core root config. |
invoke.go |
Removes top-level env application; enforces 16 MiB request/response JSON size limits. |
invoke_test.go |
Updates tests to reflect removed top-level env behavior; adds coverage for size limits and config-root env behavior. |
invoke_model.go |
Removes Env from LibXrayInvokeRequest. |
go.mod |
Pins Xray-core pseudo-version and bumps indirect dependencies accordingly. |
go.sum |
Updates checksums for the dependency bumps. |
desktop_bin/run.go |
Removes desktop wrapper implementation. |
desktop_bin/main.go |
Removes desktop wrapper entrypoint. |
build/app/windows.py |
Stops producing the wrapper binary in Windows builds. |
build/app/linux.py |
Stops producing the wrapper binary in Linux builds. |
build/app/build.py |
Removes shared helper for building the wrapper; updates default Xray-core pin. |
.github/workflows/build.yml |
Stops packaging the wrapper executable in Linux/Windows artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wejg
pushed a commit
to wejg/libXray
that referenced
this pull request
Jul 24, 2026
* 'main' of https://github.com/XTLS/libXray: add /proc/net UID fallback for Android < API 30 (XTLS#137) Update Xray-core to v26.7.11 (XTLS#136) Harden Xray lifecycle and build tooling (XTLS#135) Remove Invoke env and desktop wrapper (XTLS#134) Restore invoke env and desktop wrapper (XTLS#133) Align Invoke response models (XTLS#132) Dev 26.7 1 (XTLS#131) Merge pull request XTLS#130 from XTLS/dev-26.6-3 feat: add automated build workflow for all platforms Update Xray-core to v26.6.27 Avoid splitting share input during format checks Refine share input format detection Remove DNS resolver wrapper # Conflicts: # build/template/main.gotemplate # go.mod # go.sum # xray/ping.go # xray/xray.go # xray_wrapper.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
go test ./... -count=1git diff --check