refactor(core): stabilize v1.0.7 by removing dead code and unstable FFI dependencies#13
Merged
Merged
Conversation
V1 - WAF/CAPTCHA Detection: Add detect_waf_challenge() with 19 WAF signatures (Cloudflare, reCAPTCHA, hCaptcha, DataDome, PerimeterX, Akamai) to detect false HTTP 200 responses. Retries with UA rotation once before returning WafBlocked error. V2 - Race Condition Fix: Add fs2 file locking to state_store.rs. Exclusive lock on save(), shared lock on load() prevents data corruption with parallel instances. V4 - TUI Panic Hook: Each restoration step runs independently. Partial failures no longer corrupt terminal state. V5 - OOM Protection: Streaming size limits in sitemap_parser.rs. HTTP response capped at 50MB, GZIP decompression at 100MB. Tests: 267/267 passing (+15 new WAF tests), 0 clippy warnings.
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Remove bumpalo: arena allocator imported but never used. The Bump::new() at chunker.rs:177 was created and immediately dropped. Removing unnecessary dependency weight. Remove zvec: entire feature was a stub. ZvecExporter::is_available() always returned false, export() always returned 'not yet implemented'. The zvec-sys crate had CMake build failures. Feature flag promised functionality that didn't exist. Files deleted: src/infrastructure/export/zvec_exporter.rs (96 lines) Net: -247 lines, +16 lines across 11 files. Tests: 265/265 passing, 0 clippy warnings.
Cleaned 7 .md files removing zvec as an available feature: - README.md: feature flags table, optional deps - docs/RAG-EXPORT.md: ZvecExporter status, file tree, checklist - docs/USAGE.md: format table, Zvec Format section, troubleshooting - docs/CLI.md: format tables, examples, feature flags - docs/ARCHITECTURE.md: feature list, file tree, export module - docs/CONTRIBUTING.md: optional deps, feature flags - docs/CHANGES.md: annotated historical entry as 'removed in v1.0.7' Only 2 remaining references are intentional historical annotations.
XaviCode1000
added a commit
that referenced
this pull request
May 20, 2026
…-bumpalo refactor(core): stabilize v1.0.7 by removing dead code and unstable FFI dependencies
XaviCode1000
added a commit
that referenced
this pull request
May 20, 2026
…-bumpalo refactor(core): stabilize v1.0.7 by removing dead code and unstable FFI dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump::new()created and immediately dropped. Dead code with dependency weight.ZvecExporter::is_available()always returnedfalse,export()always returned "not yet implemented". Thezvec-syscrate required CMake/C++ and had build failures.Impact
full = [images, documents, zvec]full = [images, documents]zvec-sys)-304 net linesFiles Changed
Cargo.toml— Remove bumpalo dep + zvec feature + zvec-sys depsrc/infrastructure/ai/chunker.rs— Remove bumpalo import + dead arena codesrc/infrastructure/export/zvec_exporter.rs— Deleted (96 lines of stub)src/infrastructure/export/mod.rs— Remove zvec modulesrc/domain/entities.rs— RemoveExportFormat::Zvecvariantsrc/domain/exporter.rs— Remove zvec testssrc/export_factory.rs— Remove ZvecExporter referencessrc/lib.rs— Remove zvec re-export + docssrc/main.rs— Remove zvec validation blockREADME.md+ 6 doc files — Remove all zvec referencesVerification
cargo check— compiles cleanlycargo nextest run --test-threads 2— 265/265 passingcargo clippy -- -D warnings— zero warningsRelated