fix: load all version-specific Lua files unconditionally in TOC#37
Closed
fix: load all version-specific Lua files unconditionally in TOC#37
Conversation
WalkthroughThis change reorganizes the RaidLogAuto.toc manifest file by removing version block end markers for Retail, BCC, and Mists, restructuring the per-version file inclusion order to Retail, BCC, Mists, then Vanilla, and eliminating the Vanilla version block markers entirely. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (3 passed)
✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RaidLogAuto fails to load on BCC/Anniversary (and all non-Retail clients) because all Lua file references in the TOC are wrapped in packager comment directives (
#@version-bcc@etc.). Locally these are just comments, so WoW sees zero files to load.Changes
#@version-*@packager directives fromRaidLogAuto.tocWOW_PROJECT_IDguard at line 10 that ensures only the correct version executesThis matches DragonLoot's local-dev pattern. The packager's
enable-toc-creation: yesstill generates flavor-specific TOCs for distribution.Testing
RaidLogAuto_BCC.luavia the main TOCWOW_PROJECT_IDguard allows execution