Skip to content

fix: load all version-specific Lua files unconditionally in TOC#37

Closed
Xerrion wants to merge 1 commit intomasterfrom
fix/bcc-toc-loading
Closed

fix: load all version-specific Lua files unconditionally in TOC#37
Xerrion wants to merge 1 commit intomasterfrom
fix/bcc-toc-loading

Conversation

@Xerrion
Copy link
Copy Markdown
Owner

@Xerrion Xerrion commented Mar 15, 2026

Summary

RaidLogAuto fails to load on BCC/Anniversary (and all non-Retail clients) because all Lua file references in the TOC are wrapped in packager comment directives (#@version-bcc@ etc.). Locally these are just comments, so WoW sees zero files to load.

Changes

  • Removed #@version-*@ packager directives from RaidLogAuto.toc
  • Listed all 4 version-specific Lua files unconditionally
  • Each file already has a WOW_PROJECT_ID guard at line 10 that ensures only the correct version executes

This matches DragonLoot's local-dev pattern. The packager's enable-toc-creation: yes still generates flavor-specific TOCs for distribution.

Testing

  • Verified luacheck passes: 0 warnings, 0 errors across all 4 files
  • BCC/Anniversary client should now find and load RaidLogAuto_BCC.lua via the main TOC
  • All 4 Lua files load but only the matching WOW_PROJECT_ID guard allows execution

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 15, 2026

Walkthrough

This change reorganizes the RaidLogAuto.toc manifest file by removing version block end markers for Retail, BCC, and Mists, restructuring the per-version file inclusion order to Retail, BCC, Mists, then Vanilla, and eliminating the Vanilla version block markers entirely.

Changes

Cohort / File(s) Summary
Manifest Version Markers
RaidLogAuto.toc
Removed closing markers (end-version-bcc, end-version-mists, end-version-retail) and the complete opening/closing pair for Vanilla (version-vanilla). Reordered per-version file includes to sequence Retail and BCC ahead of Mists, with Vanilla last. These changes alter version block segmentation boundaries without modifying referenced file contents.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Conventional Commit Pr Title ❌ Error PR title contains capitalized words 'Lua' and 'TOC' that violate the conventional commit format's lowercase description requirement. Update the PR title to lowercase: 'fix: load all version-specific lua files unconditionally in toc'
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required conventional commit format (fix:) and accurately describes the main change: removing version-block markers to enable unconditional loading of version-specific Lua files.
Description check ✅ Passed The description is comprehensive and directly related to the changeset, explaining the problem (TOC packager directives preventing file loading), the solution (removing directives and listing files unconditionally), and the safety mechanism (WOW_PROJECT_ID guards).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/bcc-toc-loading
  • 🛠️ Local CI verification: Commit on current branch
  • 🛠️ Local CI verification: Create PR
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@Xerrion Xerrion closed this Mar 15, 2026
@Xerrion Xerrion deleted the fix/bcc-toc-loading branch March 15, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant