Skip to content

fix: correct packager directive end-tags and vanilla filename in TOC#35

Merged
Xerrion merged 1 commit intomasterfrom
fix/33-slash-commands-broken
Mar 15, 2026
Merged

fix: correct packager directive end-tags and vanilla filename in TOC#35
Xerrion merged 1 commit intomasterfrom
fix/33-slash-commands-broken

Conversation

@Xerrion
Copy link
Copy Markdown
Owner

@Xerrion Xerrion commented Mar 15, 2026

Summary

Fixes #33. The addon was completely non-functional on all game versions because the BigWigsMods packager TOC directives had malformed end-tags, causing no Lua files to be loaded.

Changes

  • Fixed 3 malformed packager directive end-tags in RaidLogAuto.toc: changed #@end-version-vanilla#, #@end-version-mists#, and #@end-version-retail# to use @ instead of # as the closing character (#@end-version-*@)
  • Fixed the vanilla file reference from RaidLogAuto_Classic.lua to RaidLogAuto_Vanilla.lua to match the actual filename

Root Cause

The BigWigsMods packager toc_filter function uses a sed regex /#@end-${keyword}@/ to match end-tags. The source TOC used # instead of @ as the closing character (e.g., #@end-version-retail#), which meant:

  1. For non-matching game types (e.g., vanilla/bcc/mists blocks when building retail): The sed range /#@version-vanilla@/,/#@end-version-vanilla@/d couldn't find the end-tag, so it deleted everything from the start-tag to EOF — wiping out the retail block that should have been kept
  2. Result: The generated RaidLogAuto.toc for Retail (and Mists/TBC) contained zero Lua files, so the addon loaded nothing — no event handler, no slash commands, no initialization

This was confirmed by downloading and extracting the 1.4.1 release zip — all generated TOC files except Vanilla had 0 file entries.

Testing

  • Verified the fix matches the exact regex in the packager's toc_filter() function
  • Confirmed version-vanilla is a valid alias for version-classic in the packager source
  • A new release after merge will trigger the packager and generate correct TOC files with the proper Lua file entries for each game version

Closes #33

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 15, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: fecd9d55-ef16-4e6b-8050-40c4a4623fee

📥 Commits

Reviewing files that changed from the base of the PR and between 17166d4 and 6703294.

📒 Files selected for processing (1)
  • RaidLogAuto.toc

Summary by CodeRabbit

  • Bug Fixes
    • Fixed saved variables configuration for the Vanilla version of the addon.

Walkthrough

The RaidLogAuto.toc file is updated to correct the SavedVariables reference from RaidLogAuto_Classic.lua to RaidLogAuto_Vanilla.lua, and version marker punctuation changes from # to @ for Vanilla, Mists, and Retail sections.

Changes

Cohort / File(s) Summary
TOC Configuration
RaidLogAuto.toc
SavedVariables file reference corrected from RaidLogAuto_Classic.lua to RaidLogAuto_Vanilla.lua. Version end-markers updated from # to @ for Vanilla, Mists, and Retail sections; BCC section remains unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/33-slash-commands-broken
  • 🛠️ Local CI verification: Commit on current branch
  • 🛠️ Local CI verification: Create PR
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@Xerrion Xerrion merged commit fcafaae into master Mar 15, 2026
2 of 3 checks passed
@Xerrion Xerrion deleted the fix/33-slash-commands-broken branch March 15, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: slash commands don't work

1 participant