fix: correct packager directive end-tags and vanilla filename in TOC#35
Merged
fix: correct packager directive end-tags and vanilla filename in TOC#35
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThe RaidLogAuto.toc file is updated to correct the SavedVariables reference from RaidLogAuto_Classic.lua to RaidLogAuto_Vanilla.lua, and version marker punctuation changes from # to @ for Vanilla, Mists, and Retail sections. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #33. The addon was completely non-functional on all game versions because the BigWigsMods packager TOC directives had malformed end-tags, causing no Lua files to be loaded.
Changes
RaidLogAuto.toc: changed#@end-version-vanilla#,#@end-version-mists#, and#@end-version-retail#to use@instead of#as the closing character (#@end-version-*@)RaidLogAuto_Classic.luatoRaidLogAuto_Vanilla.luato match the actual filenameRoot Cause
The BigWigsMods packager
toc_filterfunction uses a sed regex/#@end-${keyword}@/to match end-tags. The source TOC used#instead of@as the closing character (e.g.,#@end-version-retail#), which meant:/#@version-vanilla@/,/#@end-version-vanilla@/dcouldn't find the end-tag, so it deleted everything from the start-tag to EOF — wiping out the retail block that should have been keptRaidLogAuto.tocfor Retail (and Mists/TBC) contained zero Lua files, so the addon loaded nothing — no event handler, no slash commands, no initializationThis was confirmed by downloading and extracting the
1.4.1release zip — all generated TOC files except Vanilla had 0 file entries.Testing
toc_filter()functionversion-vanillais a valid alias forversion-classicin the packager sourceCloses #33