Skip to content

Conversation

@wiobber
Copy link
Collaborator

@wiobber wiobber commented Jun 18, 2025

…ary characters like underscore without throwing an error in the compile process.

xronosuf added 4 commits June 18, 2025 16:35
…ary characters like underscore without throwing an error in the compile process.
…e quote unless it is inside a string, so we need to nest double quotes inside single quotes and not the other way around, which showed up in the footnotes online display javascript, breaking it entirely. Fixed here and tested on examples.
…th the author footnotes, and future footnotes.
@xronosuf
Copy link
Collaborator

Ok, this should be all set now - the examples branch bulk pass is done. There is more to do on the examples/testbed, but any bugs that I was going to find in the original code as a result of making test files should have been found now, so this pull request should actually be ready now.

@wiobber wiobber changed the title Need a detokenize command to allow the googleSheet url to have arbitr… Bugfixes (from working on ximeraExamples) Jun 22, 2025
Copy link
Collaborator Author

@wiobber wiobber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wiobber wiobber marked this pull request as ready for review June 22, 2025 15:41
@wiobber wiobber merged commit 90fbd3e into master Jun 22, 2025
1 check passed
@wiobber wiobber deleted the examplesBugFixes branch June 22, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants