Skip to content

feat(crypto): use the ziren keccak precompile and implement ziren keccak state #32816 #32996#1991

Merged
AnilChinchawale merged 2 commits intoXinFinOrg:dev-upgradefrom
gzliudan:ziren-keccak
Feb 5, 2026
Merged

feat(crypto): use the ziren keccak precompile and implement ziren keccak state #32816 #32996#1991
AnilChinchawale merged 2 commits intoXinFinOrg:dev-upgradefrom
gzliudan:ziren-keccak

Conversation

@gzliudan
Copy link
Copy Markdown
Collaborator

Proposed changes

Ref:

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Copilot AI review requested due to automatic review settings January 26, 2026 10:03
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 26, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request integrates the Ziren zkvm keccak precompile and implements build-tag-based conditional compilation to support both standard and Ziren-optimized keccak hashing implementations.

Changes:

  • Added Ziren zkvm_runtime dependency for zk-optimized Keccak256 implementation
  • Refactored keccak implementations into separate build-tag-controlled files (ziren vs non-ziren)
  • Removed Keccak512 function (unused in the codebase)

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
go.mod Added zkvm_runtime dependency as an indirect requirement
go.sum Added checksums for the new zkvm_runtime dependency
crypto/keccak.go Standard (non-ziren) implementation of Keccak functions using golang.org/x/crypto/sha3
crypto/keccak_ziren.go Ziren-optimized implementation using zkvm_runtime precompile
crypto/crypto.go Removed Keccak function implementations and unused imports (moved to build-tag-specific files)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crypto/keccak.go Outdated
Comment thread crypto/keccak.go Outdated
Comment thread crypto/keccak_ziren.go Outdated
Uses the go module's `replace` directive to delegate keccak computation
to precompiles.

This is still in draft because it needs more testing. Also, it relies on
a PR that I created, that hasn't been merged yet.

_Note that this PR doesn't implement the stateful keccak state
structure, and it reverts to the current behavior. This is a bit silly
since this is what is used in the tree root computation. The runtime
doesn't currently export the sponge. I will see if I can fix that in a
further PR, but it is going to take more time. In the meantime, this is
a useful first step_
The ethereum#32816 was only using the keccak precompile for some minor task.
This PR implements a keccak state, which is what is used for hashing the
tree.
@gzliudan gzliudan changed the title crypto: use the ziren keccak precompile and implement ziren keccak state #32816 #32996 feat(crypto): use the ziren keccak precompile and implement ziren keccak state #32816 #32996 Feb 5, 2026
@AnilChinchawale AnilChinchawale merged commit 99749a2 into XinFinOrg:dev-upgrade Feb 5, 2026
13 checks passed
@gzliudan gzliudan deleted the ziren-keccak branch February 5, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants