feat(p2p): add egress/ingress traffic metrics to discv5 udp transport #16369#2011
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds ingress/egress traffic metering for the discv5 UDP transport to improve network observability.
Changes:
- Register new discv5-specific inbound/outbound traffic meters.
- Mark outbound UDP bytes on successful sends.
- Mark inbound UDP bytes for received packets.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| p2p/discv5/udp.go | Adds byte-count metering on UDP send/receive paths. |
| p2p/discv5/metrics.go | Registers new discv5 inbound/outbound traffic meters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
038dd6d to
6d409b7
Compare
6d409b7 to
e2f7fba
Compare
Proposed changes
Ref: ethereum#16369
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that