Skip to content

feat(core/vm): implement EIP-7823 - Set upper bounds for MODEXP #31818 #32363#2119

Merged
AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:eip-7823
Mar 6, 2026
Merged

feat(core/vm): implement EIP-7823 - Set upper bounds for MODEXP #31818 #32363#2119
AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:eip-7823

Conversation

@gzliudan
Copy link
Copy Markdown
Collaborator

Proposed changes

https://eips.ethereum.org/EIPS/eip-7823

Ref:

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Changes that don't change source code or tests
  • docs: Documentation only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • revert: Revert something
  • style: Changes that do not affect the meaning of the code
  • test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 27, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gzliudan gzliudan changed the title feat(core/vm): implement EIP 7823 - Set upper bounds for MODEXP #31818 #32363 feat(core/vm): implement EIP-7823 - Set upper bounds for MODEXP #31818 #32363 Feb 27, 2026
@gzliudan gzliudan changed the title feat(core/vm): implement EIP-7823 - Set upper bounds for MODEXP #31818 #32363 feat(core/vm): implement EIP-7823 #31818 #32363 Feb 27, 2026
Copilot AI review requested due to automatic review settings March 2, 2026 02:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements the EIP-7823 changes for the modexp (big modular exponentiation) precompile by introducing an Osaka fork precompile set and enforcing an input-size cap when Osaka rules are active.

Changes:

  • Adds an Osaka precompile set (PrecompiledContractsOsaka) and selects it when rules.IsOsaka is active.
  • Extends the bigModExp precompile with an eip7823 toggle and enforces a 1024-byte cap on base/exponent/modulus lengths in Run.
  • Updates existing precompile sets to include the new eip7823 field in bigModExp literals.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread core/vm/contracts.go Outdated
Comment thread core/vm/contracts.go
Comment thread core/vm/contracts.go
Comment thread core/vm/contracts.go
@gzliudan gzliudan force-pushed the eip-7823 branch 3 times, most recently from c00cadc to b38874d Compare March 3, 2026 10:09
@gzliudan gzliudan changed the title feat(core/vm): implement EIP-7823 #31818 #32363 feat(core/vm): implement EIP-7823 - Set upper bounds for MODEXP #31818 #32363 Mar 3, 2026
@AnilChinchawale AnilChinchawale merged commit d542efe into XinFinOrg:dev-upgrade Mar 6, 2026
13 checks passed
@gzliudan gzliudan deleted the eip-7823 branch March 6, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants