Update functions.image.php#116
Merged
mambax7 merged 3 commits intoXoopsModules25x:masterfrom Feb 18, 2021
Merged
Conversation
Removing the height value can lead to CLS. So the better option is to add a height: auto style tag and restore the height value. This way the browser knows the size of the image ahead of time and calculates the height based on the available max-width. Thereby preventing the CLS from happening.
One more change so the image when viewed without a thumbnail has the correct width and height set for the browser.
Removed un-needed px markers from width and height markers since those are not in a style tag, they are not needed.
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the height value can lead to CLS. So the better option is to add a height: auto style tag and restore the height value. This way the browser knows the size of the image ahead of time and calculates the height based on the available max-width. Thereby preventing the CLS from happening.