Skip to content

Improve settings discoverability#147

Merged
Xoshbin merged 2 commits into
Xoshbin:mainfrom
AllDaGearNoIdea:feat/settings-discoverability
Apr 8, 2026
Merged

Improve settings discoverability#147
Xoshbin merged 2 commits into
Xoshbin:mainfrom
AllDaGearNoIdea:feat/settings-discoverability

Conversation

@AllDaGearNoIdea

Copy link
Copy Markdown
Contributor

Summary

Settings was only accessible via the action panel (Cmd+K), or from the menu bar. This makes it easier to find:

  • Cmd/Ctrl+, keyboard shortcut opens the settings window (standard macOS convention)
  • "Settings" appears in search results as a built-in command, so typing "settings" in the launcher finds it directly

Test plan

  • Press Cmd+, (or Ctrl+, on Linux) — settings window opens
  • Type "settings" in the launcher — "Settings" appears as a search result with "Asyar" label on the right
  • Select the "Settings" result — settings window opens and launcher hides
  • pnpm test passes

AllDaGearNoIdea and others added 2 commits April 8, 2026 00:09
Add Cmd/Ctrl+, keyboard shortcut to open settings (standard macOS
convention). Register Settings as a searchable built-in command so
it appears in launcher search results.
- manifest: name "Settings", type "result", command description corrected
- launcherKeyboard: replace dynamic import with static commands call
- tests: add Cmd/Ctrl+, cases to launcherKeyboard.test.ts
@Xoshbin

Xoshbin commented Apr 8, 2026

Copy link
Copy Markdown
Owner

Thanks for the contribution — the goal is solid. Applied a few small fixes before merging: corrected the manifest name/description/type fields, swapped the dynamic import for the existing static commands reference, and added test coverage for the new keyboard handler.

@Xoshbin
Xoshbin merged commit 47b7b5e into Xoshbin:main Apr 8, 2026
1 check passed
@Xoshbin

Xoshbin commented Apr 8, 2026

Copy link
Copy Markdown
Owner

@AllDaGearNoIdea Hey, I noticed your commits are showing up with the default GitHub icon. You might want to check your local git config (git config user.email) and make sure it matches an email verified on your GitHub account so you get the contributor credit!

@AllDaGearNoIdea

Copy link
Copy Markdown
Contributor Author

Thanks @Xoshbin I've updated by global settings and pushed a correction to the open PR

@AllDaGearNoIdea
AllDaGearNoIdea deleted the feat/settings-discoverability branch April 8, 2026 10:29
Xoshbin added a commit that referenced this pull request May 24, 2026
- manifest: name "Settings", type "result", command description corrected
- launcherKeyboard: replace dynamic import with static commands call
- tests: add Cmd/Ctrl+, cases to launcherKeyboard.test.ts
Xoshbin added a commit that referenced this pull request May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants