fix(launcher): unify dialog keyboard/focus handling onto a native Modal component

[Xoshbin]

No description provided.

[gemini-code-assist]

Code Review

This pull request refactors the application's dialogs by replacing custom modal overlays with a unified, native <dialog>-backed Modal component, updating global keyboard handlers to prevent key leaks when modals are open. The review feedback suggests enhancing the isActionableElementFocused helper to correctly handle HTMLSelectElement, button-like HTMLInputElement types, and contenteditable elements, as well as refining getFirstFocusable to skip hidden inputs and adding corresponding unit tests.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

The getFirstFocusable helper is used to find a fallback focus target inside the dialog. However, it currently does not filter out hidden inputs (<input type="hidden">), which are matched by FOCUSABLE_SELECTOR but are not focusable. Additionally, checking both the disabled attribute and the disabled property ensures maximum compatibility across different browsers and test environments (like jsdom).

We should update the loop to skip hidden inputs and check both the attribute and property for disabled states.

Suggested change

	export function getFirstFocusable(container: HTMLElement): HTMLElement | null {
	const candidates = container.querySelectorAll<HTMLElement>(FOCUSABLE_SELECTOR);
	for (let i = 0; i < candidates.length; i++) {
	const el = candidates[i];
	if (el.hasAttribute('disabled')) continue;
	if (el.tabIndex < 0) continue;
	return el;
	}
	return null;
	}
	export function getFirstFocusable(container: HTMLElement): HTMLElement | null {
	const candidates = container.querySelectorAll<HTMLElement>(FOCUSABLE_SELECTOR);
	for (let i = 0; i < candidates.length; i++) {
	const el = candidates[i];
	if (el.hasAttribute('disabled') || (el as any).disabled) continue;
	if (el instanceof HTMLInputElement && el.type === 'hidden') continue;
	if (el.tabIndex < 0) continue;
	return el;
	}
	return null;
	}

[gemini-code-assist]

To ensure the new actionable element checks are thoroughly verified and regression-proof, we should add unit tests for HTMLSelectElement, actionable HTMLInputElement types, and contenteditable elements.

  it('returns true for a textarea (Enter should insert a newline, not submit)', () => {
    const textarea = document.createElement('textarea');
    expect(isActionableElementFocused(textarea)).toBe(true);
  });

  it('returns true for a select element', () => {
    const select = document.createElement('select');
    expect(isActionableElementFocused(select)).toBe(true);
  });

  it('returns true for actionable input types', () => {
    const submit = document.createElement('input');
    submit.type = 'submit';
    expect(isActionableElementFocused(submit)).toBe(true);

    const button = document.createElement('input');
    button.type = 'button';
    expect(isActionableElementFocused(button)).toBe(true);
  });

  it('returns true for contenteditable elements', () => {
    const div = document.createElement('div');
    div.contentEditable = 'true';
    expect(isActionableElementFocused(div)).toBe(true);
  });
});