test: add README quickstart search regression test#20
Conversation
kriptoburak
left a comment
There was a problem hiding this comment.
The offline test passes locally and its assertions match the README flow. Three repository requirements remain:
- Rebase onto the current
Xquik-dev/mainbranch. - Add the repository's standard SPDX copyright and Apache-2.0 header to
tests/test_readme_quickstart.py. - Add a final newline and certify your commit with your own DCO sign-off.
A safe command sequence after editing is:
git fetch https://github.com/Xquik-dev/x-twitter-scraper-python.git main
git rebase FETCH_HEAD
git add tests/test_readme_quickstart.py
git commit --amend --no-edit --signoff
git push --force-with-leaseThe Signed-off-by identity must match your commit author. A maintainer cannot certify your contribution. I will rerun the full hosted and local gates after your update.
Signed-off-by: Asritha916 <masritha06@gmail.com>
693c663 to
424f24b
Compare
Signed-off-by: kriptoburak <kriptoburak@users.noreply.github.com>
|
The contributor completed the rebase, SPDX, and author-matching DCO requirements. I added only the missing final newline in signed-off commit |
All requested changes were completed on the current head.
furkanerday
left a comment
There was a problem hiding this comment.
Reviewed the complete diff, description, discussion, repository policies, public contracts, relevant tests, required checks, and commit sign-offs at 4a0ca25. All required checks pass, no unresolved threads remain, and I found no blocking issue.
|
Thanks @kriptoburak and @furkanerday for the reviews and guidance throughout this PR. This was my first open-source contribution, and I learned a lot from the process. I really appreciate your time and support! |
Summary
Add an offline regression test for the README search quickstart.
Changes
Closes #19
Note
Add regression test for
XTwitterScraper.x.tweets.searchREADME quickstartAdds a pytest test in test_readme_quickstart.py that mocks a GET to
/x/tweets/searchusingrespxand verifies that the client sends the correctqandlimitquery parameters. Also checks that the response is parsed into the expected result fields, includinghas_next_pageand tweet text.Macroscope summarized facd806.