New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share tweaks #2357

Merged
merged 2 commits into from Jan 15, 2018

Conversation

Projects
None yet
3 participants
@dgw
Collaborator

dgw commented Jan 14, 2018

This is two separate small tweaks to the share.js code, one of which fixes #2352 (the other is just because I was in the file already and saw it).

One or the other can be cherry-picked, or I can just merge both. If both, I'll probably squash it to one commit before merging because the changes are both minor and proximate.

@JayHoltslander this is the PR I promised, a couple days later than planned but not forgotten!

dgw added some commits Jan 14, 2018

Use HTTPS for Twitter/Facebook sharers
As long as I was touching the share code, it seemed silly to leave plain
HTTP links in there.

@ozh ozh merged commit 143a2e8 into YOURLS:master Jan 15, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dgw

This comment has been minimized.

Collaborator

dgw commented Jan 15, 2018

Guess I won't squash then 😹

@dgw dgw deleted the dgw:share-tweaks branch Jan 15, 2018

@ozh

This comment has been minimized.

Member

ozh commented Jan 15, 2018

I have stopped a long time ago paying attention and putting efforts into a cleaner commit log. I think that's a sad waste of time. 2 commits for 2 tiny stuff? No problem :)

freuds added a commit to freuds/YOURLS that referenced this pull request Jan 18, 2018

Merge pull request #2 from YOURLS/master
 Merge pull request YOURLS#2357 from dgw/share-tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment