Merged
Conversation
As long as I was touching the share code, it seemed silly to leave plain HTTP links in there.
LeoColomb
approved these changes
Jan 14, 2018
Member
Author
|
Guess I won't squash then 😹 |
Member
|
I have stopped a long time ago paying attention and putting efforts into a cleaner commit log. I think that's a sad waste of time. 2 commits for 2 tiny stuff? No problem :) |
freuds
added a commit
to freuds/YOURLS
that referenced
this pull request
Jan 18, 2018
Merge pull request YOURLS#2357 from dgw/share-tweaks
tomtenuta
pushed a commit
to tomtenuta/YOURLS
that referenced
this pull request
Nov 4, 2025
Share tweaks: https + 280 chars on Twitter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is two separate small tweaks to the
share.jscode, one of which fixes #2352 (the other is just because I was in the file already and saw it).One or the other can be cherry-picked, or I can just merge both. If both, I'll probably squash it to one commit before merging because the changes are both minor and proximate.
@JayHoltslander this is the PR I promised, a couple days later than planned but not forgotten!