feat: Updated protoc to 3.20.3 - #7
Merged
Merged
Conversation
`protoc-gen-js` was removed in more recent version of Protocol Buffers. Ref: protocolbuffers/protobuf-javascript#127 Closes YePpHa#4 Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
YePpHa
approved these changes
Oct 29, 2022
YePpHa
left a comment
YePpHa
left a comment
Owner
There was a problem hiding this comment.
Looks fine. I'll release an update.
Owner
|
@dankeboy36 I've published a new version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
protocversion to3.20.3. The PR proposes the removal ofdarwin_x86_32, there is no such artifact, and the arm64 is not yet available for3.20.3.Closes #4
Signed-off-by: dankeboy36 dankeboy36@gmail.com
Initially, I wanted to pick the most recent version of protoc (
3.21.9), but the support ofprotoc-gen-jswas removed (protocolbuffers/protobuf-javascript#127), so I picked the latest backward compatibleprotocversion.For example:
Please review. Thank you!